Skip to content

Commit

Permalink
[PATCH] Char: mxser_new, clean request_irq call
Browse files Browse the repository at this point in the history
We always set ASYNC_SHARE_IRQ, so do not test against this flag and request
shared irq directly.  Also remove nonsense comment.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Jiri Slaby authored and Linus Torvalds committed Feb 11, 2007
1 parent 47c85c0 commit c493edd
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions drivers/char/mxser_new.c
Original file line number Diff line number Diff line change
Expand Up @@ -2398,13 +2398,9 @@ static int __devinit mxser_initbrd(struct mxser_board *brd,
outb(inb(info->ioaddr + UART_IER) & 0xf0,
info->ioaddr + UART_IER);
}
/*
* Allocate the IRQ if necessary
*/

retval = request_irq(brd->irq, mxser_interrupt,
(brd->ports[0].flags & ASYNC_SHARE_IRQ) ? IRQF_SHARED :
IRQF_DISABLED, "mxser", brd);
retval = request_irq(brd->irq, mxser_interrupt, IRQF_SHARED, "mxser",
brd);
if (retval) {
printk(KERN_ERR "Board %s: Request irq failed, IRQ (%d) may "
"conflict with another device.\n",
Expand Down

0 comments on commit c493edd

Please sign in to comment.