Skip to content

Commit

Permalink
[PKT_SCHED] RED: Fix overflow in calculation of queue average
Browse files Browse the repository at this point in the history
Overflow can occur very easily with 32 bits, e.g., with 1 second
us_idle is approx. 2^20, which leaves only 11-Wlog bits for queue
length. Since the EWMA exponent is typically around 9, queue
lengths larger than 2^2 cause overflow. Whether the affected
branch is taken when us_idle is as high as 1 second, depends on
Scell_log, but with rather reasonable configuration Scell_log is
large enough to cause p->Stab to have zero index, which always
results zero shift (typically also few other small indices result
in zero shift).

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Ilpo Järvinen authored and David S. Miller committed Aug 5, 2006
1 parent 30a584d commit c4c0ce5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion include/net/red.h
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ static inline unsigned long red_calc_qavg_from_idle_time(struct red_parms *p)
* Seems, it is the best solution to
* problem of too coarse exponent tabulation.
*/
us_idle = (p->qavg * us_idle) >> p->Scell_log;
us_idle = (p->qavg * (u64)us_idle) >> p->Scell_log;

if (us_idle < (p->qavg >> 1))
return p->qavg - us_idle;
Expand Down

0 comments on commit c4c0ce5

Please sign in to comment.