Skip to content

Commit

Permalink
wl12xx: fix error handling in wl12xx_probe()
Browse files Browse the repository at this point in the history
Resources were not freed properly in some cases.

Signed-off-by: Kalle Valo <kalle.valo@nokia.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Kalle Valo authored and John W. Linville committed Jul 10, 2009
1 parent 1d3b813 commit c4f5c85
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions drivers/net/wireless/wl12xx/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -1274,13 +1274,15 @@ static int __devinit wl12xx_probe(struct spi_device *spi)
wl->set_power = pdata->set_power;
if (!wl->set_power) {
wl12xx_error("set power function missing in platform data");
return -ENODEV;
ret = -ENODEV;
goto out_free;
}

wl->irq = spi->irq;
if (wl->irq < 0) {
wl12xx_error("irq missing in platform data");
return -ENODEV;
ret = -ENODEV;
goto out_free;
}

ret = request_irq(wl->irq, wl12xx_irq, 0, DRIVER_NAME, wl);
Expand Down

0 comments on commit c4f5c85

Please sign in to comment.