Skip to content

Commit

Permalink
ath9k: Make sure we configure a non-zero beacon interval
Browse files Browse the repository at this point in the history
This patch moves the sanity check on beacon interval
which was done only for mesh mode to all operating
modes just to be safe.

Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Vasanthakumar Thiagarajan authored and John W. Linville committed Jul 10, 2009
1 parent e0d6133 commit c4f9f16
Showing 1 changed file with 8 additions and 7 deletions.
15 changes: 8 additions & 7 deletions drivers/net/wireless/ath/ath9k/beacon.c
Original file line number Diff line number Diff line change
Expand Up @@ -674,13 +674,6 @@ static void ath_beacon_config_adhoc(struct ath_softc *sc,

intval = conf->beacon_interval & ATH9K_BEACON_PERIOD;

/*
* It looks like mac80211 may end up using beacon interval of zero in
* some cases (at least for mesh point). Avoid getting into an
* infinite loop by using a bit safer value instead..
*/
if (intval == 0)
intval = 100;

/* Pull nexttbtt forward to reflect the current TSF */

Expand Down Expand Up @@ -745,6 +738,14 @@ void ath_beacon_config(struct ath_softc *sc, struct ieee80211_vif *vif)
iftype = sc->sc_ah->opmode;
}

/*
* It looks like mac80211 may end up using beacon interval of zero in
* some cases (at least for mesh point). Avoid getting into an
* infinite loop by using a bit safer value instead. To be safe,
* do sanity check on beacon interval for all operating modes.
*/
if (cur_conf->beacon_interval == 0)
cur_conf->beacon_interval = 100;

switch (iftype) {
case NL80211_IFTYPE_AP:
Expand Down

0 comments on commit c4f9f16

Please sign in to comment.