Skip to content

Commit

Permalink
wait_task_zombie: remove ->exit_state/exit_signal checks for WNOWAIT
Browse files Browse the repository at this point in the history
The first "p->exit_state != EXIT_ZOMBIE" check doesn't make too much sense.
The exit_state was EXIT_ZOMBIE when the function was called, and another
thread can change it to EXIT_DEAD right after the check.

The second condition is not possible, detached non-traced threads were already
filtered out by eligible_child(), we didn't drop tasklist since then.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Oleg Nesterov authored and Linus Torvalds committed Feb 8, 2008
1 parent 3a515e4 commit c543f1e
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions kernel/exit.c
Original file line number Diff line number Diff line change
Expand Up @@ -1196,10 +1196,6 @@ static int wait_task_zombie(struct task_struct *p, int noreap,
int exit_code = p->exit_code;
int why, status;

if (unlikely(p->exit_state != EXIT_ZOMBIE))
return 0;
if (unlikely(p->exit_signal == -1 && p->ptrace == 0))
return 0;
get_task_struct(p);
read_unlock(&tasklist_lock);
if ((exit_code & 0x7f) == 0) {
Expand Down

0 comments on commit c543f1e

Please sign in to comment.