Skip to content

Commit

Permalink
powerpc/mm: Add better comment on careful_allocation()
Browse files Browse the repository at this point in the history
The behavior in careful_allocation() really confused me
at first.  Add a comment to hopefully make it easier
on the next doofus that looks at it.

Signed-off-by: Dave Hansen <dave@linux.vnet.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
  • Loading branch information
Dave Hansen authored and Benjamin Herrenschmidt committed Jan 8, 2009
1 parent afcb065 commit c555e52
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions arch/powerpc/mm/numa.c
Original file line number Diff line number Diff line change
Expand Up @@ -840,8 +840,16 @@ static void __init *careful_allocation(int nid, unsigned long size,
size, nid);

/*
* If the memory came from a previously allocated node, we must
* retry with the bootmem allocator.
* We initialize the nodes in numeric order: 0, 1, 2...
* and hand over control from the LMB allocator to the
* bootmem allocator. If this function is called for
* node 5, then we know that all nodes <5 are using the
* bootmem allocator instead of the LMB allocator.
*
* So, check the nid from which this allocation came
* and double check to see if we need to use bootmem
* instead of the LMB. We don't free the LMB memory
* since it would be useless.
*/
new_nid = early_pfn_to_nid(ret >> PAGE_SHIFT);
if (new_nid < nid) {
Expand Down

0 comments on commit c555e52

Please sign in to comment.