Skip to content

Commit

Permalink
misc: pti, use tty_port_register_device
Browse files Browse the repository at this point in the history
So now we have enough of tty_ports, so we can signal the TTY layer to
use them by tty_port_register_device.

The upside is that we look like we can introduce tty_port_easy_open
and put it directly as tty_operations->open to drivers doing nothing
in open and using tty_port_register_device. Because the easy open can
obtain a tty_port rather easily from a tty now. Heh, what a nice
by-product.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: J Freyensee <james_p_freyensee@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Jiri Slaby authored and Greg Kroah-Hartman committed Aug 10, 2012
1 parent 5bd4200 commit c565ee0
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/misc/pti.c
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@ static int pti_tty_driver_open(struct tty_struct *tty, struct file *filp)
* also removes a locking requirement for the actual write
* procedure.
*/
return tty_port_open(&drv_data->port[tty->index], tty, filp);
return tty_port_open(tty->port, tty, filp);
}

/**
Expand All @@ -443,7 +443,7 @@ static int pti_tty_driver_open(struct tty_struct *tty, struct file *filp)
*/
static void pti_tty_driver_close(struct tty_struct *tty, struct file *filp)
{
tty_port_close(&drv_data->port[tty->index], tty, filp);
tty_port_close(tty->port, tty, filp);
}

/**
Expand Down Expand Up @@ -856,7 +856,7 @@ static int __devinit pti_pci_probe(struct pci_dev *pdev,
tty_port_init(port);
port->ops = &tty_port_ops;

tty_register_device(pti_tty_driver, a, &pdev->dev);
tty_port_register_device(port, pti_tty_driver, a, &pdev->dev);
}

register_console(&pti_console);
Expand Down

0 comments on commit c565ee0

Please sign in to comment.