Skip to content

Commit

Permalink
Staging: hv: Get rid of blkvsc_mutex
Browse files Browse the repository at this point in the history
The blkvsc_mutex is unnecessary as the state it is protecting
(blkdev->users) is already protected by the spin lock.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Abhishek Kane <v-abkane@microsoft.com>
Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
K. Y. Srinivasan authored and Greg Kroah-Hartman committed May 11, 2011
1 parent ca8f352 commit c566249
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions drivers/staging/hv/blkvsc_drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
#include <linux/major.h>
#include <linux/delay.h>
#include <linux/hdreg.h>
#include <linux/mutex.h>
#include <linux/slab.h>
#include <scsi/scsi.h>
#include <scsi/scsi_cmnd.h>
Expand Down Expand Up @@ -113,8 +112,6 @@ struct block_device_context {
int users;
};

static DEFINE_MUTEX(blkvsc_mutex);

static const char *g_blk_driver_name = "blkvsc";

/* {32412632-86cb-44a2-9b5c-50d1417354f5} */
Expand Down Expand Up @@ -620,7 +617,6 @@ static int blkvsc_release(struct gendisk *disk, fmode_t mode)
{
struct block_device_context *blkdev = disk->private_data;

mutex_lock(&blkvsc_mutex);
spin_lock(&blkdev->lock);
if (blkdev->users == 1) {
spin_unlock(&blkdev->lock);
Expand All @@ -631,7 +627,6 @@ static int blkvsc_release(struct gendisk *disk, fmode_t mode)
blkdev->users--;

spin_unlock(&blkdev->lock);
mutex_unlock(&blkvsc_mutex);
return 0;
}

Expand Down

0 comments on commit c566249

Please sign in to comment.