Skip to content

Commit

Permalink
perf session: Fix possible null pointer dereference in session.c
Browse files Browse the repository at this point in the history
cppcheck detected following warning:
[tools/perf/util/session.c:1628] -> [tools/perf/util/session.c:1632]:
 (warning) Possible null pointer dereference: session - otherwise it
 is redundant to check it against null.

In order to avoide null pointer, check the pointer before use.

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Link: http://lkml.kernel.org/r/1400087618-13628-1-git-send-email-standby24x7@gmail.com
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
  • Loading branch information
Masanari Iida authored and Jiri Olsa committed May 16, 2014
1 parent 9d372ca commit c5765ec
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions tools/perf/util/session.c
Original file line number Diff line number Diff line change
Expand Up @@ -1625,13 +1625,14 @@ int perf_session__cpu_bitmap(struct perf_session *session,
void perf_session__fprintf_info(struct perf_session *session, FILE *fp,
bool full)
{
int fd = perf_data_file__fd(session->file);
struct stat st;
int ret;
int fd, ret;

if (session == NULL || fp == NULL)
return;

fd = perf_data_file__fd(session->file);

ret = fstat(fd, &st);
if (ret == -1)
return;
Expand Down

0 comments on commit c5765ec

Please sign in to comment.