Skip to content

Commit

Permalink
RDMA/ocrdma: Remove write-only variables
Browse files Browse the repository at this point in the history
Signed-off-by: Roland Dreier <roland@purestorage.com>
  • Loading branch information
Roland Dreier committed May 8, 2012
1 parent e9db295 commit c592c42
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 10 deletions.
6 changes: 2 additions & 4 deletions drivers/infiniband/hw/ocrdma/ocrdma_hw.c
Original file line number Diff line number Diff line change
Expand Up @@ -2293,7 +2293,6 @@ int ocrdma_mbx_modify_qp(struct ocrdma_dev *dev, struct ocrdma_qp *qp,
{
int status = -ENOMEM;
struct ocrdma_modify_qp *cmd;
struct ocrdma_modify_qp_rsp *rsp;

cmd = ocrdma_init_emb_mqe(OCRDMA_CMD_MODIFY_QP, sizeof(*cmd));
if (!cmd)
Expand All @@ -2317,7 +2316,7 @@ int ocrdma_mbx_modify_qp(struct ocrdma_dev *dev, struct ocrdma_qp *qp,
status = ocrdma_mbx_cmd(dev, (struct ocrdma_mqe *)cmd);
if (status)
goto mbx_err;
rsp = (struct ocrdma_modify_qp_rsp *)cmd;

mbx_err:
kfree(cmd);
return status;
Expand All @@ -2327,7 +2326,6 @@ int ocrdma_mbx_destroy_qp(struct ocrdma_dev *dev, struct ocrdma_qp *qp)
{
int status = -ENOMEM;
struct ocrdma_destroy_qp *cmd;
struct ocrdma_destroy_qp_rsp *rsp;
struct pci_dev *pdev = dev->nic_info.pdev;

cmd = ocrdma_init_emb_mqe(OCRDMA_CMD_DELETE_QP, sizeof(*cmd));
Expand All @@ -2337,7 +2335,7 @@ int ocrdma_mbx_destroy_qp(struct ocrdma_dev *dev, struct ocrdma_qp *qp)
status = ocrdma_mbx_cmd(dev, (struct ocrdma_mqe *)cmd);
if (status)
goto mbx_err;
rsp = (struct ocrdma_destroy_qp_rsp *)cmd;

mbx_err:
kfree(cmd);
if (qp->sq.va)
Expand Down
6 changes: 0 additions & 6 deletions drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
Original file line number Diff line number Diff line change
Expand Up @@ -625,12 +625,10 @@ struct ib_mr *ocrdma_reg_user_mr(struct ib_pd *ibpd, u64 start, u64 len,
struct ocrdma_dev *dev;
struct ocrdma_mr *mr;
struct ocrdma_pd *pd;
struct pci_dev *pdev;
u32 num_pbes;

pd = get_ocrdma_pd(ibpd);
dev = pd->dev;
pdev = dev->nic_info.pdev;

if (acc & IB_ACCESS_REMOTE_WRITE && !(acc & IB_ACCESS_LOCAL_WRITE))
return ERR_PTR(-EINVAL);
Expand Down Expand Up @@ -1596,10 +1594,8 @@ int ocrdma_modify_srq(struct ib_srq *ibsrq,
{
int status = 0;
struct ocrdma_srq *srq;
struct ocrdma_dev *dev;

srq = get_ocrdma_srq(ibsrq);
dev = srq->dev;
if (srq_attr_mask & IB_SRQ_MAX_WR)
status = -EINVAL;
else
Expand All @@ -1611,10 +1607,8 @@ int ocrdma_query_srq(struct ib_srq *ibsrq, struct ib_srq_attr *srq_attr)
{
int status;
struct ocrdma_srq *srq;
struct ocrdma_dev *dev;

srq = get_ocrdma_srq(ibsrq);
dev = srq->dev;
status = ocrdma_mbx_query_srq(srq, srq_attr);
return status;
}
Expand Down

0 comments on commit c592c42

Please sign in to comment.