Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 332105
b: refs/heads/master
c: 13c57e5
h: refs/heads/master
i:
  332103: 629ff5b
v: v3
  • Loading branch information
Timur Tabi authored and Mark Brown committed Sep 19, 2012
1 parent 86dddb8 commit c5cb99d
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 51 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: d41789b2660e5b18b8401bf83ebcd502916c2cb5
refs/heads/master: 13c57e5b868b4f023f6436d8c6a079eaffd7f3a8
32 changes: 7 additions & 25 deletions trunk/sound/soc/fsl/mpc8610_hpcd.c
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,6 @@ static int mpc8610_hpcd_probe(struct platform_device *pdev)
container_of(dev, struct platform_device, dev);
struct device_node *np = ssi_pdev->dev.of_node;
struct device_node *codec_np = NULL;
struct platform_device *sound_device = NULL;
struct mpc8610_hpcd_data *machine_data;
int ret = -ENODEV;
const char *sprop;
Expand Down Expand Up @@ -341,34 +340,22 @@ static int mpc8610_hpcd_probe(struct platform_device *pdev)
machine_data->card.probe = mpc8610_hpcd_machine_probe;
machine_data->card.remove = mpc8610_hpcd_machine_remove;
machine_data->card.name = pdev->name; /* The platform driver name */
machine_data->card.owner = THIS_MODULE;
machine_data->card.dev = &pdev->dev;
machine_data->card.num_links = 2;
machine_data->card.dai_link = machine_data->dai;

/* Allocate a new audio platform device structure */
sound_device = platform_device_alloc("soc-audio", -1);
if (!sound_device) {
dev_err(&pdev->dev, "platform device alloc failed\n");
ret = -ENOMEM;
goto error;
}

/* Associate the card data with the sound device */
platform_set_drvdata(sound_device, &machine_data->card);

/* Register with ASoC */
ret = platform_device_add(sound_device);
ret = snd_soc_register_card(&machine_data->card);
if (ret) {
dev_err(&pdev->dev, "platform device add failed\n");
goto error_sound;
dev_err(&pdev->dev, "could not register card\n");
goto error;
}
dev_set_drvdata(&pdev->dev, sound_device);

of_node_put(codec_np);

return 0;

error_sound:
platform_device_put(sound_device);
error:
kfree(machine_data);
error_alloc:
Expand All @@ -383,17 +370,12 @@ static int mpc8610_hpcd_probe(struct platform_device *pdev)
*/
static int __devexit mpc8610_hpcd_remove(struct platform_device *pdev)
{
struct platform_device *sound_device = dev_get_drvdata(&pdev->dev);
struct snd_soc_card *card = platform_get_drvdata(sound_device);
struct snd_soc_card *card = platform_get_drvdata(pdev);
struct mpc8610_hpcd_data *machine_data =
container_of(card, struct mpc8610_hpcd_data, card);

platform_device_unregister(sound_device);

snd_soc_unregister_card(card);
kfree(machine_data);
sound_device->dev.platform_data = NULL;

dev_set_drvdata(&pdev->dev, NULL);

return 0;
}
Expand Down
31 changes: 6 additions & 25 deletions trunk/sound/soc/fsl/p1022_ds.c
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,6 @@ static int p1022_ds_probe(struct platform_device *pdev)
container_of(dev, struct platform_device, dev);
struct device_node *np = ssi_pdev->dev.of_node;
struct device_node *codec_np = NULL;
struct platform_device *sound_device = NULL;
struct machine_data *mdata;
int ret = -ENODEV;
const char *sprop;
Expand Down Expand Up @@ -349,36 +348,23 @@ static int p1022_ds_probe(struct platform_device *pdev)
mdata->card.probe = p1022_ds_machine_probe;
mdata->card.remove = p1022_ds_machine_remove;
mdata->card.name = pdev->name; /* The platform driver name */
mdata->card.owner = THIS_MODULE;
mdata->card.dev = &pdev->dev;
mdata->card.num_links = 2;
mdata->card.dai_link = mdata->dai;

/* Allocate a new audio platform device structure */
sound_device = platform_device_alloc("soc-audio", -1);
if (!sound_device) {
dev_err(&pdev->dev, "platform device alloc failed\n");
ret = -ENOMEM;
goto error;
}

/* Associate the card data with the sound device */
platform_set_drvdata(sound_device, &mdata->card);

/* Register with ASoC */
ret = platform_device_add(sound_device);
ret = snd_soc_register_card(&mdata->card);
if (ret) {
dev_err(&pdev->dev, "platform device add failed\n");
dev_err(&pdev->dev, "could not register card\n");
goto error;
}
dev_set_drvdata(&pdev->dev, sound_device);

of_node_put(codec_np);

return 0;

error:
if (sound_device)
platform_device_put(sound_device);

kfree(mdata);
error_put:
of_node_put(codec_np);
Expand All @@ -392,17 +378,12 @@ static int p1022_ds_probe(struct platform_device *pdev)
*/
static int __devexit p1022_ds_remove(struct platform_device *pdev)
{
struct platform_device *sound_device = dev_get_drvdata(&pdev->dev);
struct snd_soc_card *card = platform_get_drvdata(sound_device);
struct snd_soc_card *card = platform_get_drvdata(pdev);
struct machine_data *mdata =
container_of(card, struct machine_data, card);

platform_device_unregister(sound_device);

snd_soc_unregister_card(card);
kfree(mdata);
sound_device->dev.platform_data = NULL;

dev_set_drvdata(&pdev->dev, NULL);

return 0;
}
Expand Down

0 comments on commit c5cb99d

Please sign in to comment.