Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 158493
b: refs/heads/master
c: 62f0b3e
h: refs/heads/master
i:
  158491: f2aac61
v: v3
  • Loading branch information
Steven Rostedt authored and Steven Rostedt committed Sep 4, 2009
1 parent ac5b23f commit c63940c
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 4 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: e8165dbb03ed04d798163ee512074b9a9466a9c8
refs/heads/master: 62f0b3eb5cb58931a02ee4e599e19c80a171e351
20 changes: 17 additions & 3 deletions trunk/kernel/trace/ring_buffer.c
Original file line number Diff line number Diff line change
Expand Up @@ -2073,7 +2073,8 @@ static void rb_end_commit(struct ring_buffer_per_cpu *cpu_buffer)
}

static struct ring_buffer_event *
rb_reserve_next_event(struct ring_buffer_per_cpu *cpu_buffer,
rb_reserve_next_event(struct ring_buffer *buffer,
struct ring_buffer_per_cpu *cpu_buffer,
unsigned long length)
{
struct ring_buffer_event *event;
Expand All @@ -2083,6 +2084,19 @@ rb_reserve_next_event(struct ring_buffer_per_cpu *cpu_buffer,

rb_start_commit(cpu_buffer);

/*
* Due to the ability to swap a cpu buffer from a buffer
* it is possible it was swapped before we committed.
* (committing stops a swap). We check for it here and
* if it happened, we have to fail the write.
*/
barrier();
if (unlikely(ACCESS_ONCE(cpu_buffer->buffer) != buffer)) {
local_dec(&cpu_buffer->committing);
local_dec(&cpu_buffer->commits);
return NULL;
}

length = rb_calculate_event_length(length);
again:
/*
Expand Down Expand Up @@ -2243,7 +2257,7 @@ ring_buffer_lock_reserve(struct ring_buffer *buffer, unsigned long length)
if (length > BUF_MAX_DATA_SIZE)
goto out;

event = rb_reserve_next_event(cpu_buffer, length);
event = rb_reserve_next_event(buffer, cpu_buffer, length);
if (!event)
goto out;

Expand Down Expand Up @@ -2476,7 +2490,7 @@ int ring_buffer_write(struct ring_buffer *buffer,
if (length > BUF_MAX_DATA_SIZE)
goto out;

event = rb_reserve_next_event(cpu_buffer, length);
event = rb_reserve_next_event(buffer, cpu_buffer, length);
if (!event)
goto out;

Expand Down

0 comments on commit c63940c

Please sign in to comment.