Skip to content

Commit

Permalink
drivers/net: normalize TX_TIMEOUT
Browse files Browse the repository at this point in the history
Some network drivers use old TX_TIMEOUT definitions, assuming HZ=100 of
old kernels.

Convert these definitions to include HZ, since HZ can be 1000 these
days.

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Eric Dumazet authored and David S. Miller committed Nov 9, 2010
1 parent 973a34a commit c63fdf4
Show file tree
Hide file tree
Showing 10 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion drivers/net/3c507.c
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ struct net_local {
#define RX_BUF_SIZE (1518+14+18) /* packet+header+RBD */
#define RX_BUF_END (dev->mem_end - dev->mem_start)

#define TX_TIMEOUT 5
#define TX_TIMEOUT (HZ/20)

/*
That's it: only 86 bytes to set up the beast, including every extra
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/3c515.c
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ static int rx_nocopy, rx_copy, queued_packet;
#define WAIT_TX_AVAIL 200

/* Operational parameter that usually are not changed. */
#define TX_TIMEOUT 40 /* Time in jiffies before concluding Tx hung */
#define TX_TIMEOUT ((4*HZ)/10) /* Time in jiffies before concluding Tx hung */

/* The size here is somewhat misleading: the Corkscrew also uses the ISA
aliased registers at <base>+0x400.
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/82596.c
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ enum commands {
#define RX_SUSPEND 0x0030
#define RX_ABORT 0x0040

#define TX_TIMEOUT 5
#define TX_TIMEOUT (HZ/20)


struct i596_reg {
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/arm/w90p910_ether.c
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@
#define TX_DESC_SIZE 10
#define MAX_RBUFF_SZ 0x600
#define MAX_TBUFF_SZ 0x600
#define TX_TIMEOUT 50
#define TX_TIMEOUT (HZ/2)
#define DELAY 1000
#define CAM0 0x0

Expand Down
2 changes: 1 addition & 1 deletion drivers/net/at1700.c
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ struct net_local {
#define PORT_OFFSET(o) (o)


#define TX_TIMEOUT 10
#define TX_TIMEOUT (HZ/10)


/* Index to functions, as function prototypes. */
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/atarilance.c
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ MODULE_LICENSE("GPL");
#define RX_RING_LEN_BITS (RX_LOG_RING_SIZE << 5)
#define RX_RING_MOD_MASK (RX_RING_SIZE - 1)

#define TX_TIMEOUT 20
#define TX_TIMEOUT (HZ/5)

/* The LANCE Rx and Tx ring descriptors. */
struct lance_rx_head {
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/eepro.c
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ struct eepro_local {
#define ee_id_eepro10p0 0x10 /* ID for eepro/10+ */
#define ee_id_eepro10p1 0x31

#define TX_TIMEOUT 40
#define TX_TIMEOUT ((4*HZ)/10)

/* Index to functions, as function prototypes. */

Expand Down
2 changes: 1 addition & 1 deletion drivers/net/lance.c
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ tx_full and tbusy flags.
#define LANCE_BUS_IF 0x16
#define LANCE_TOTAL_SIZE 0x18

#define TX_TIMEOUT 20
#define TX_TIMEOUT (HZ/5)

/* The LANCE Rx and Tx ring descriptors. */
struct lance_rx_head {
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/lib82596.c
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ enum commands {
#define RX_SUSPEND 0x0030
#define RX_ABORT 0x0040

#define TX_TIMEOUT 5
#define TX_TIMEOUT (HZ/20)


struct i596_reg {
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/znet.c
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ MODULE_LICENSE("GPL");
#define TX_BUF_SIZE 8192
#define DMA_BUF_SIZE (RX_BUF_SIZE + 16) /* 8k + 16 bytes for trailers */

#define TX_TIMEOUT 10
#define TX_TIMEOUT (HZ/10)

struct znet_private {
int rx_dma, tx_dma;
Expand Down

0 comments on commit c63fdf4

Please sign in to comment.