Skip to content

Commit

Permalink
ptrace: cleanup ptrace_init_task()->ptrace_link() path
Browse files Browse the repository at this point in the history
No functional changes.

ptrace_init_task() looks confusing, as if we always auto-attach when "bool
ptrace" argument is true, while in fact we attach only if current is
traced.

Make the code more explicit and kill now unused ptrace_link().

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Oleg Nesterov authored and Linus Torvalds committed Dec 16, 2009
1 parent aa20d48 commit c6a47cc
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions include/linux/ptrace.h
Original file line number Diff line number Diff line change
Expand Up @@ -105,12 +105,7 @@ static inline int ptrace_reparented(struct task_struct *child)
{
return child->real_parent != child->parent;
}
static inline void ptrace_link(struct task_struct *child,
struct task_struct *new_parent)
{
if (unlikely(child->ptrace))
__ptrace_link(child, new_parent);
}

static inline void ptrace_unlink(struct task_struct *child)
{
if (unlikely(child->ptrace))
Expand Down Expand Up @@ -169,9 +164,9 @@ static inline void ptrace_init_task(struct task_struct *child, bool ptrace)
INIT_LIST_HEAD(&child->ptraced);
child->parent = child->real_parent;
child->ptrace = 0;
if (unlikely(ptrace)) {
if (unlikely(ptrace) && (current->ptrace & PT_PTRACED)) {
child->ptrace = current->ptrace;
ptrace_link(child, current->parent);
__ptrace_link(child, current->parent);
}
}

Expand Down

0 comments on commit c6a47cc

Please sign in to comment.