Skip to content

Commit

Permalink
backlight: tps65217_bl: Add missing platform_set_drvdata in tps65217_…
Browse files Browse the repository at this point in the history
…bl_probe

Otherwise, we got NULL derefernce while calling backlight_device_unregister()
in tps65217_bl_remove().

Also convert to use module_platform_driver.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
  • Loading branch information
Axel Lin authored and Samuel Ortiz committed Sep 30, 2012
1 parent 2896434 commit c6bed9d
Showing 1 changed file with 2 additions and 12 deletions.
14 changes: 2 additions & 12 deletions drivers/video/backlight/tps65217_bl.c
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,7 @@ static int tps65217_bl_probe(struct platform_device *pdev)
}

tps65217_bl->bl->props.brightness = 0;
platform_set_drvdata(pdev, tps65217_bl);

return 0;
}
Expand All @@ -334,18 +335,7 @@ static struct platform_driver tps65217_bl_driver = {
},
};

static int __init tps65217_bl_init(void)
{
return platform_driver_register(&tps65217_bl_driver);
}

static void __exit tps65217_bl_exit(void)
{
platform_driver_unregister(&tps65217_bl_driver);
}

module_init(tps65217_bl_init);
module_exit(tps65217_bl_exit);
module_platform_driver(tps65217_bl_driver);

MODULE_DESCRIPTION("TPS65217 Backlight driver");
MODULE_LICENSE("GPL v2");
Expand Down

0 comments on commit c6bed9d

Please sign in to comment.