Skip to content

Commit

Permalink
Use a separate config option for the b43 pci to ssb bridge.
Browse files Browse the repository at this point in the history
The bridge code was unnecessary enabled by the b44
driver, but it prevents the bcm43xx driver from
being loaded, as the bridge claims the same pci ids.

Now we enable the birdge only if the b43{legacy}
drivers are selected.

Signed-off-by: Alexey Zaytsev <alexey.zaytsev@gmail.com>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Alexey Zaytsev authored and John W. Linville committed Feb 28, 2008
1 parent 4b7524a commit c708453
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 3 deletions.
1 change: 1 addition & 0 deletions drivers/net/wireless/b43/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ config B43_PCI_AUTOSELECT
bool
depends on B43 && SSB_PCIHOST_POSSIBLE
select SSB_PCIHOST
select SSB_B43_PCI_BRIDGE
default y

# Auto-select SSB PCICORE driver, if possible
Expand Down
1 change: 1 addition & 0 deletions drivers/net/wireless/b43legacy/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ config B43LEGACY_PCI_AUTOSELECT
bool
depends on B43LEGACY && SSB_PCIHOST_POSSIBLE
select SSB_PCIHOST
select SSB_B43_PCI_BRIDGE
default y

# Auto-select SSB PCICORE driver, if possible
Expand Down
5 changes: 5 additions & 0 deletions drivers/ssb/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,11 @@ config SSB_PCIHOST

If unsure, say Y

config SSB_B43_PCI_BRIDGE
bool
depends on SSB_PCIHOST
default n

config SSB_PCMCIAHOST_POSSIBLE
bool
depends on SSB && (PCMCIA = y || PCMCIA = SSB) && EXPERIMENTAL
Expand Down
2 changes: 1 addition & 1 deletion drivers/ssb/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ ssb-$(CONFIG_SSB_DRIVER_PCICORE) += driver_pcicore.o

# b43 pci-ssb-bridge driver
# Not strictly a part of SSB, but kept here for convenience
ssb-$(CONFIG_SSB_PCIHOST) += b43_pci_bridge.o
ssb-$(CONFIG_SSB_B43_PCI_BRIDGE) += b43_pci_bridge.o

obj-$(CONFIG_SSB) += ssb.o
4 changes: 2 additions & 2 deletions drivers/ssb/ssb_private.h
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,10 @@ extern int ssb_devices_thaw(struct ssb_bus *bus);
extern struct ssb_bus *ssb_pci_dev_to_bus(struct pci_dev *pdev);

/* b43_pci_bridge.c */
#ifdef CONFIG_SSB_PCIHOST
#ifdef CONFIG_SSB_B43_PCI_BRIDGE
extern int __init b43_pci_ssb_bridge_init(void);
extern void __exit b43_pci_ssb_bridge_exit(void);
#else /* CONFIG_SSB_PCIHOST */
#else /* CONFIG_SSB_B43_PCI_BRIDGR */
static inline int b43_pci_ssb_bridge_init(void)
{
return 0;
Expand Down

0 comments on commit c708453

Please sign in to comment.