Skip to content

Commit

Permalink
usb: renesas_usbhs: fixup fifo disable
Browse files Browse the repository at this point in the history
It was necessary to check pipe condition after disable fifo.
Current driver checked it in a wrong place.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Kuninori Morimoto authored and Greg Kroah-Hartman committed May 11, 2011
1 parent fd5054c commit c786e09
Showing 1 changed file with 13 additions and 16 deletions.
29 changes: 13 additions & 16 deletions drivers/usb/renesas_usbhs/pipe.c
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,6 @@ static void usbhsp_pipe_select(struct usbhs_pipe *pipe)
static int usbhsp_pipe_barrier(struct usbhs_pipe *pipe)
{
struct usbhs_priv *priv = usbhsp_pipe_to_priv(pipe);
struct device *dev = usbhs_priv_to_dev(priv);
int timeout = 1024;
u16 val;

Expand All @@ -206,6 +205,7 @@ static int usbhsp_pipe_barrier(struct usbhs_pipe *pipe)
* - "Pipe Control Registers Switching Procedure"
*/
usbhs_write(priv, CFIFOSEL, 0);
usbhs_fifo_disable(pipe);

do {
val = usbhsp_pipectrl_get(pipe);
Expand All @@ -217,21 +217,6 @@ static int usbhsp_pipe_barrier(struct usbhs_pipe *pipe)

} while (timeout--);

/*
* force NAK
*/
timeout = 1024;
usbhs_fifo_disable(pipe);
do {
val = usbhsp_pipectrl_get(pipe);
val &= PBUSY;
if (!val)
return 0;

} while (timeout--);

dev_err(dev, "pipe barrier failed\n");

return -EBUSY;
}

Expand Down Expand Up @@ -270,10 +255,22 @@ static void __usbhsp_pid_try_nak_if_stall(struct usbhs_pipe *pipe)

void usbhs_fifo_disable(struct usbhs_pipe *pipe)
{
int timeout = 1024;
u16 val;

/* see "Pipe n Control Register" - "PID" */
__usbhsp_pid_try_nak_if_stall(pipe);

usbhsp_pipectrl_set(pipe, PID_MASK, PID_NAK);

do {
val = usbhsp_pipectrl_get(pipe);
val &= PBUSY;
if (!val)
break;

udelay(10);
} while (timeout--);
}

void usbhs_fifo_enable(struct usbhs_pipe *pipe)
Expand Down

0 comments on commit c786e09

Please sign in to comment.