Skip to content

Commit

Permalink
KVM: VMX: move APIC_ACCESS trace entry to generic code
Browse files Browse the repository at this point in the history
This patch moves the trace entry for APIC accesses from the VMX code to the
generic lapic code. This way APIC accesses from SVM will also be traced.

Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
Signed-off-by: Avi Kivity <avi@qumranet.com>
  • Loading branch information
Joerg Roedel authored and Avi Kivity committed Jul 20, 2008
1 parent 8b2cf73 commit c7bf23b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 4 additions & 0 deletions arch/x86/kvm/lapic.c
Original file line number Diff line number Diff line change
Expand Up @@ -572,6 +572,8 @@ static u32 __apic_read(struct kvm_lapic *apic, unsigned int offset)
{
u32 val = 0;

KVMTRACE_1D(APIC_ACCESS, apic->vcpu, (u32)offset, handler);

if (offset >= LAPIC_MMIO_LENGTH)
return 0;

Expand Down Expand Up @@ -695,6 +697,8 @@ static void apic_mmio_write(struct kvm_io_device *this,

offset &= 0xff0;

KVMTRACE_1D(APIC_ACCESS, apic->vcpu, (u32)offset, handler);

switch (offset) {
case APIC_ID: /* Local APIC ID */
apic_set_reg(apic, APIC_ID, val);
Expand Down
2 changes: 0 additions & 2 deletions arch/x86/kvm/vmx.c
Original file line number Diff line number Diff line change
Expand Up @@ -2554,8 +2554,6 @@ static int handle_apic_access(struct kvm_vcpu *vcpu, struct kvm_run *kvm_run)
exit_qualification = vmcs_read64(EXIT_QUALIFICATION);
offset = exit_qualification & 0xffful;

KVMTRACE_1D(APIC_ACCESS, vcpu, (u32)offset, handler);

er = emulate_instruction(vcpu, kvm_run, 0, 0, 0);

if (er != EMULATE_DONE) {
Expand Down

0 comments on commit c7bf23b

Please sign in to comment.