Skip to content

Commit

Permalink
net/fec: replace hardcoded irq num with macro
Browse files Browse the repository at this point in the history
Don't use hardcoded irq num and replace it with
FEC_IRQ_NUM macro.

Signed-off-by: Xiao Jiang <jgq516@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Xiao Jiang authored and David S. Miller committed Sep 29, 2011
1 parent 2e11437 commit c7c83d1
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions drivers/net/ethernet/freescale/fec.c
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,8 @@ MODULE_PARM_DESC(macaddr, "FEC Ethernet MAC address");
#define PKT_MINBUF_SIZE 64
#define PKT_MAXBLR_SIZE 1520

/* This device has up to three irqs on some platforms */
#define FEC_IRQ_NUM 3

/*
* The 5270/5271/5280/5282/532x RX control register also contains maximum frame
Expand Down Expand Up @@ -1540,8 +1542,7 @@ fec_probe(struct platform_device *pdev)

fec_reset_phy(pdev);

/* This device has up to three irqs on some platforms */
for (i = 0; i < 3; i++) {
for (i = 0; i < FEC_IRQ_NUM; i++) {
irq = platform_get_irq(pdev, i);
if (i && irq < 0)
break;
Expand Down Expand Up @@ -1586,7 +1587,7 @@ fec_probe(struct platform_device *pdev)
clk_disable(fep->clk);
clk_put(fep->clk);
failed_clk:
for (i = 0; i < 3; i++) {
for (i = 0; i < FEC_IRQ_NUM; i++) {
irq = platform_get_irq(pdev, i);
if (irq > 0)
free_irq(irq, ndev);
Expand Down

0 comments on commit c7c83d1

Please sign in to comment.