Skip to content

Commit

Permalink
[TCP]: Fix scatterlist handling in MD5 signature support.
Browse files Browse the repository at this point in the history
Use sg_init_table() and sg_mark_end() as needed.

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David S. Miller committed Oct 26, 2007
1 parent 0e0940d commit c7da57a
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
5 changes: 5 additions & 0 deletions net/ipv4/tcp_ipv4.c
Original file line number Diff line number Diff line change
Expand Up @@ -1055,6 +1055,9 @@ static int tcp_v4_do_calc_md5_hash(char *md5_hash, struct tcp_md5sig_key *key,
bp->pad = 0;
bp->protocol = protocol;
bp->len = htons(tcplen);

sg_init_table(sg, 4);

sg_set_buf(&sg[block++], bp, sizeof(*bp));
nbytes += sizeof(*bp);

Expand All @@ -1080,6 +1083,8 @@ static int tcp_v4_do_calc_md5_hash(char *md5_hash, struct tcp_md5sig_key *key,
sg_set_buf(&sg[block++], key->key, key->keylen);
nbytes += key->keylen;

sg_mark_end(sg, block);

/* Now store the Hash into the packet */
err = crypto_hash_init(desc);
if (err)
Expand Down
4 changes: 4 additions & 0 deletions net/ipv6/tcp_ipv6.c
Original file line number Diff line number Diff line change
Expand Up @@ -757,6 +757,8 @@ static int tcp_v6_do_calc_md5_hash(char *md5_hash, struct tcp_md5sig_key *key,
bp->len = htonl(tcplen);
bp->protocol = htonl(protocol);

sg_init_table(sg, 4);

sg_set_buf(&sg[block++], bp, sizeof(*bp));
nbytes += sizeof(*bp);

Expand All @@ -778,6 +780,8 @@ static int tcp_v6_do_calc_md5_hash(char *md5_hash, struct tcp_md5sig_key *key,
sg_set_buf(&sg[block++], key->key, key->keylen);
nbytes += key->keylen;

sg_mark_end(sg, block);

/* Now store the hash into the packet */
err = crypto_hash_init(desc);
if (err) {
Expand Down

0 comments on commit c7da57a

Please sign in to comment.