Skip to content

Commit

Permalink
kprobes/x86: Remove an incorrect comment about int3 in NMI/MCE
Browse files Browse the repository at this point in the history
Remove a comment about an int3 issue in NMI/MCE, since
commit:

  3f3c8b8 ("x86: Add workaround to NMI iret woes")

already fixed that. Keeping this incorrect comment can mislead developers.

Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Reviewed-by: Jiri Kosina <jkosina@suse.cz>
Cc: H. Peter Anvin <hpa@linux.intel.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Jason Baron <jbaron@akamai.com>
Cc: yrl.pp-manager.tt@hitachi.com
Cc: Borislav Petkov <bpetkov@suse.de>
Link: http://lkml.kernel.org/r/20130718114747.26675.84110.stgit@mhiramat-M0-7522
Signed-off-by: Ingo Molnar <mingo@kernel.org>
  • Loading branch information
Masami Hiramatsu authored and Ingo Molnar committed Jul 19, 2013
1 parent 9bb1542 commit c7e85c4
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions arch/x86/kernel/kprobes/opt.c
Original file line number Diff line number Diff line change
Expand Up @@ -415,11 +415,6 @@ void __kprobes arch_optimize_kprobes(struct list_head *oplist)
break;
}

/*
* text_poke_smp doesn't support NMI/MCE code modifying.
* However, since kprobes itself also doesn't support NMI/MCE
* code probing, it's not a problem.
*/
text_poke_smp_batch(jump_poke_params, c);
}

Expand Down Expand Up @@ -455,11 +450,6 @@ extern void arch_unoptimize_kprobes(struct list_head *oplist,
break;
}

/*
* text_poke_smp doesn't support NMI/MCE code modifying.
* However, since kprobes itself also doesn't support NMI/MCE
* code probing, it's not a problem.
*/
text_poke_smp_batch(jump_poke_params, c);
}

Expand Down

0 comments on commit c7e85c4

Please sign in to comment.