Skip to content

Commit

Permalink
[NET]: Disallow whitespace in network device names.
Browse files Browse the repository at this point in the history
It causes way too much trouble and confusion in userspace.

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David S. Miller committed Aug 17, 2006
1 parent d4274b5 commit c7fa9d1
Showing 1 changed file with 14 additions and 5 deletions.
19 changes: 14 additions & 5 deletions net/core/dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@
#include <linux/audit.h>
#include <linux/dmaengine.h>
#include <linux/err.h>
#include <linux/ctype.h>

/*
* The list of packet types we will receive (as opposed to discard)
Expand Down Expand Up @@ -632,14 +633,22 @@ struct net_device * dev_get_by_flags(unsigned short if_flags, unsigned short mas
* @name: name string
*
* Network device names need to be valid file names to
* to allow sysfs to work
* to allow sysfs to work. We also disallow any kind of
* whitespace.
*/
int dev_valid_name(const char *name)
{
return !(*name == '\0'
|| !strcmp(name, ".")
|| !strcmp(name, "..")
|| strchr(name, '/'));
if (*name == '\0')
return 0;
if (!strcmp(name, ".") || !strcmp(name, ".."))
return 0;

while (*name) {
if (*name == '/' || isspace(*name))
return 0;
name++;
}
return 1;
}

/**
Expand Down

0 comments on commit c7fa9d1

Please sign in to comment.