Skip to content

Commit

Permalink
x86: fix build error with post-merge of tip/cpus4096 and rr-for-ingo/…
Browse files Browse the repository at this point in the history
…master.

Ingo Molnar wrote:

> allyes64 build failure:
>
> arch/x86/kernel/io_apic.c: In function ‘set_ir_ioapic_affinity_irq_desc’:
> arch/x86/kernel/io_apic.c:2295: error: incompatible type for argument 2 of
> ‘migrate_ioapic_irq_desc’
> arch/x86/kernel/io_apic.c: In function ‘ir_set_msi_irq_affinity’:
> arch/x86/kernel/io_apic.c:3205: error: incompatible type for argument 2 of
> ‘set_extra_move_desc’
> make[1]: *** wait: No child processes.  Stop.

Here's a small patch to correct the build error with the post-merge tree.
Built and boot-tested.  I'll will reset the follow on patches in my brand
new git tree to accommodate this change.

Fix two references in io_apic.c that were incorrect.

Signed-off-by: Mike Travis <travis@sgi.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Mike Travis authored and Ingo Molnar committed Dec 16, 2008
1 parent c3895b0 commit c8cae54
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions arch/x86/kernel/io_apic.c
Original file line number Diff line number Diff line change
Expand Up @@ -2292,7 +2292,7 @@ static void set_ir_ioapic_affinity_irq_desc(struct irq_desc *desc,
return;
}

migrate_ioapic_irq_desc(desc, mask);
migrate_ioapic_irq_desc(desc, *mask);
}
static void set_ir_ioapic_affinity_irq(unsigned int irq,
const struct cpumask *mask)
Expand Down Expand Up @@ -3203,7 +3203,7 @@ static void ir_set_msi_irq_affinity(unsigned int irq,
if (assign_irq_vector(irq, cfg, *mask))
return;

set_extra_move_desc(desc, mask);
set_extra_move_desc(desc, *mask);

cpumask_and(&tmp, &cfg->domain, mask);
dest = cpu_mask_to_apicid(tmp);
Expand Down

0 comments on commit c8cae54

Please sign in to comment.