Skip to content

Commit

Permalink
[PATCH] USB: fix usb-skeleton limit resource usage patch.
Browse files Browse the repository at this point in the history
Prevents a compiler warning and uses down_interruptible() instead of down() in
process context.

Signed-off-by: Sam Bishop <sam@bishop.dhs.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Sam Bishop authored and Greg Kroah-Hartman committed Jan 4, 2006
1 parent cb5b3f6 commit c8dd770
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions drivers/usb/usb-skeleton.c
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ static ssize_t skel_write(struct file *file, const char *user_buffer, size_t cou
int retval = 0;
struct urb *urb = NULL;
char *buf = NULL;
size_t writesize = min(count, MAX_TRANSFER);
size_t writesize = min(count, (size_t)MAX_TRANSFER);

dev = (struct usb_skel *)file->private_data;

Expand All @@ -175,7 +175,10 @@ static ssize_t skel_write(struct file *file, const char *user_buffer, size_t cou
goto exit;

/* limit the number of URBs in flight to stop a user from using up all RAM */
down (&dev->limit_sem);
if (down_interruptible(&dev->limit_sem)) {
retval = -ERESTARTSYS;
goto exit;
}

/* create a urb, and a buffer for it, and copy the data to the urb */
urb = usb_alloc_urb(0, GFP_KERNEL);
Expand Down

0 comments on commit c8dd770

Please sign in to comment.