Skip to content

Commit

Permalink
OMAPDSS: APPLY: Remove unnecessary call to mg_clear_shadow_dirty
Browse files Browse the repository at this point in the history
When doing a manual update in dss_mgr_start_update, we clear the shadow dirty
flags. Although there isn't any harm in clearing them. The need to clear them
out here should never arrive.

When applying configurations for a manual update manager, we never do any
register writes, i.e, calls to dss_mgr_write_regs and dss_mgr_write_regs_extra
never happen while applying. We do all these writes only when we call
dss_mgr_start_update. Hence, there is never a time when the shadow registers
are dirty.

Remove the call to mg_clear_shadow_dirty.

Signed-off-by: Archit Taneja <archit@ti.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
  • Loading branch information
Archit Taneja authored and Tomi Valkeinen committed Nov 12, 2012
1 parent ca8d4e8 commit c909290
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/video/omap2/dss/apply.c
Original file line number Diff line number Diff line change
Expand Up @@ -770,8 +770,6 @@ void dss_mgr_start_update(struct omap_overlay_manager *mgr)

dispc_mgr_enable_sync(mgr->id);

mgr_clear_shadow_dirty(mgr);

spin_unlock_irqrestore(&data_lock, flags);
}

Expand Down

0 comments on commit c909290

Please sign in to comment.