Skip to content

Commit

Permalink
sfc: Survive ISR0=0 bug in the shared IRQ case
Browse files Browse the repository at this point in the history
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Guido Barzini authored and David S. Miller committed Feb 4, 2010
1 parent 2e80340 commit c91f48d
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions drivers/net/sfc/nic.c
Original file line number Diff line number Diff line change
Expand Up @@ -1384,6 +1384,15 @@ static irqreturn_t efx_legacy_interrupt(int irq, void *dev_id)
efx->last_irq_cpu = raw_smp_processor_id();
EFX_TRACE(efx, "IRQ %d on CPU %d status " EFX_DWORD_FMT "\n",
irq, raw_smp_processor_id(), EFX_DWORD_VAL(reg));
} else if (EFX_WORKAROUND_15783(efx)) {
/* We can't return IRQ_HANDLED more than once on seeing ISR0=0
* because this might be a shared interrupt, but we do need to
* check the channel every time and preemptively rearm it if
* it's idle. */
efx_for_each_channel(channel, efx) {
if (!channel->work_pending)
efx_nic_eventq_read_ack(channel);
}
}

return result;
Expand Down

0 comments on commit c91f48d

Please sign in to comment.