Skip to content

Commit

Permalink
[INET]: Consolidate frag queues freeing
Browse files Browse the repository at this point in the history
Since we now allocate the queues in inet_fragment.c, we
can safely free it in the same place. The ->destructor
callback thus becomes optional for inet_frags.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Pavel Emelyanov authored and David S. Miller committed Oct 18, 2007
1 parent 48d6005 commit c954770
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 14 deletions.
4 changes: 3 additions & 1 deletion net/ipv4/inet_fragment.c
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,9 @@ void inet_frag_destroy(struct inet_frag_queue *q, struct inet_frags *f,
*work -= f->qsize;
atomic_sub(f->qsize, &f->mem);

f->destructor(q);
if (f->destructor)
f->destructor(q);
kfree(q);

}
EXPORT_SYMBOL(inet_frag_destroy);
Expand Down
1 change: 0 additions & 1 deletion net/ipv4/ip_fragment.c
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,6 @@ static __inline__ void ip4_frag_free(struct inet_frag_queue *q)
qp = container_of(q, struct ipq, q);
if (qp->peer)
inet_putpeer(qp->peer);
kfree(qp);
}


Expand Down
7 changes: 1 addition & 6 deletions net/ipv6/netfilter/nf_conntrack_reasm.c
Original file line number Diff line number Diff line change
Expand Up @@ -130,11 +130,6 @@ static inline void frag_kfree_skb(struct sk_buff *skb, unsigned int *work)
kfree_skb(skb);
}

static void nf_frag_free(struct inet_frag_queue *q)
{
kfree(container_of(q, struct nf_ct_frag6_queue, q));
}

/* Destruction primitives. */

static __inline__ void fq_put(struct nf_ct_frag6_queue *fq)
Expand Down Expand Up @@ -682,7 +677,7 @@ int nf_ct_frag6_init(void)
nf_frags.ctl = &nf_frags_ctl;
nf_frags.hashfn = nf_hashfn;
nf_frags.constructor = ip6_frag_init;
nf_frags.destructor = nf_frag_free;
nf_frags.destructor = NULL;
nf_frags.skb_free = nf_skb_free;
nf_frags.qsize = sizeof(struct nf_ct_frag6_queue);
nf_frags.match = ip6_frag_match;
Expand Down
7 changes: 1 addition & 6 deletions net/ipv6/reassembly.c
Original file line number Diff line number Diff line change
Expand Up @@ -175,11 +175,6 @@ void ip6_frag_init(struct inet_frag_queue *q, void *a)
}
EXPORT_SYMBOL(ip6_frag_init);

static void ip6_frag_free(struct inet_frag_queue *fq)
{
kfree(container_of(fq, struct frag_queue, q));
}

/* Destruction primitives. */

static __inline__ void fq_put(struct frag_queue *fq)
Expand Down Expand Up @@ -645,7 +640,7 @@ void __init ipv6_frag_init(void)
ip6_frags.ctl = &ip6_frags_ctl;
ip6_frags.hashfn = ip6_hashfn;
ip6_frags.constructor = ip6_frag_init;
ip6_frags.destructor = ip6_frag_free;
ip6_frags.destructor = NULL;
ip6_frags.skb_free = NULL;
ip6_frags.qsize = sizeof(struct frag_queue);
ip6_frags.match = ip6_frag_match;
Expand Down

0 comments on commit c954770

Please sign in to comment.