Skip to content

Commit

Permalink
[ARM] Fix SMP irqflags support
Browse files Browse the repository at this point in the history
The IRQ changes a while back broke the build for SMP machines.
Fix up the SMP code to use set_irq_regs/get_irq_regs as
appropriate.  Also, fix a warning in arch/arm/kernel/time.c
where 'regs' becomes unused for SMP builds.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
  • Loading branch information
Russell King authored and Russell King committed Oct 28, 2006
1 parent 858cbcd commit c97d486
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 9 deletions.
20 changes: 13 additions & 7 deletions arch/arm/kernel/smp.c
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
* it under the terms of the GNU General Public License version 2 as
* published by the Free Software Foundation.
*/
#include <linux/module.h>
#include <linux/delay.h>
#include <linux/init.h>
#include <linux/spinlock.h>
Expand All @@ -19,6 +20,7 @@
#include <linux/cpu.h>
#include <linux/smp.h>
#include <linux/seq_file.h>
#include <linux/irq.h>

#include <asm/atomic.h>
#include <asm/cacheflush.h>
Expand Down Expand Up @@ -474,25 +476,26 @@ void show_local_irqs(struct seq_file *p)
seq_putc(p, '\n');
}

static void ipi_timer(struct pt_regs *regs)
static void ipi_timer(void)
{
int user = user_mode(regs);

irq_enter();
profile_tick(CPU_PROFILING, regs);
update_process_times(user);
profile_tick(CPU_PROFILING);
update_process_times(user_mode(get_irq_regs()));
irq_exit();
}

#ifdef CONFIG_LOCAL_TIMERS
asmlinkage void do_local_timer(struct pt_regs *regs)
{
struct pt_regs *old_regs = set_irq_regs(regs);
int cpu = smp_processor_id();

if (local_timer_ack()) {
irq_stat[cpu].local_timer_irqs++;
ipi_timer(regs);
ipi_timer();
}

set_irq_regs(old_regs);
}
#endif

Expand Down Expand Up @@ -551,6 +554,7 @@ asmlinkage void do_IPI(struct pt_regs *regs)
{
unsigned int cpu = smp_processor_id();
struct ipi_data *ipi = &per_cpu(ipi_data, cpu);
struct pt_regs *old_regs = set_irq_regs(regs);

ipi->ipi_count++;

Expand All @@ -574,7 +578,7 @@ asmlinkage void do_IPI(struct pt_regs *regs)

switch (nextmsg) {
case IPI_TIMER:
ipi_timer(regs);
ipi_timer();
break;

case IPI_RESCHEDULE:
Expand All @@ -599,6 +603,8 @@ asmlinkage void do_IPI(struct pt_regs *regs)
}
} while (msgs);
}

set_irq_regs(old_regs);
}

void smp_send_reschedule(int cpu)
Expand Down
3 changes: 1 addition & 2 deletions arch/arm/kernel/time.c
Original file line number Diff line number Diff line change
Expand Up @@ -327,13 +327,12 @@ EXPORT_SYMBOL(restore_time_delta);
*/
void timer_tick(void)
{
struct pt_regs *regs = get_irq_regs();
profile_tick(CPU_PROFILING);
do_leds();
do_set_rtc();
do_timer(1);
#ifndef CONFIG_SMP
update_process_times(user_mode(regs));
update_process_times(user_mode(get_irq_regs()));
#endif
}

Expand Down

0 comments on commit c97d486

Please sign in to comment.