Skip to content

Commit

Permalink
drm/i915: convert PIPE_MSA_MISC to transcoder
Browse files Browse the repository at this point in the history
Same as the other registers. This one also appeared on Haswell for the
first time, so that's why we are renaming it.

Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
  • Loading branch information
Paulo Zanoni authored and Daniel Vetter committed Oct 26, 2012
1 parent 702e7a5 commit c980979
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 18 deletions.
19 changes: 10 additions & 9 deletions drivers/gpu/drm/i915/i915_reg.h
Original file line number Diff line number Diff line change
Expand Up @@ -4556,15 +4556,16 @@
#define TRANS_CLK_SEL_DISABLED (0x0<<29)
#define TRANS_CLK_SEL_PORT(x) ((x+1)<<29)

#define _PIPEA_MSA_MISC 0x60410
#define _PIPEB_MSA_MISC 0x61410
#define PIPE_MSA_MISC(pipe) _PIPE(pipe, _PIPEA_MSA_MISC, _PIPEB_MSA_MISC)
#define PIPE_MSA_SYNC_CLK (1<<0)
#define PIPE_MSA_6_BPC (0<<5)
#define PIPE_MSA_8_BPC (1<<5)
#define PIPE_MSA_10_BPC (2<<5)
#define PIPE_MSA_12_BPC (3<<5)
#define PIPE_MSA_16_BPC (4<<5)
#define _TRANSA_MSA_MISC 0x60410
#define _TRANSB_MSA_MISC 0x61410
#define TRANS_MSA_MISC(tran) _TRANSCODER(tran, _TRANSA_MSA_MISC, \
_TRANSB_MSA_MISC)
#define TRANS_MSA_SYNC_CLK (1<<0)
#define TRANS_MSA_6_BPC (0<<5)
#define TRANS_MSA_8_BPC (1<<5)
#define TRANS_MSA_10_BPC (2<<5)
#define TRANS_MSA_12_BPC (3<<5)
#define TRANS_MSA_16_BPC (4<<5)

/* LCPLL Control */
#define LCPLL_CTL 0x130040
Expand Down
18 changes: 9 additions & 9 deletions drivers/gpu/drm/i915/intel_ddi.c
Original file line number Diff line number Diff line change
Expand Up @@ -888,32 +888,32 @@ void intel_ddi_set_pipe_settings(struct drm_crtc *crtc)
struct drm_i915_private *dev_priv = crtc->dev->dev_private;
struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
struct intel_encoder *intel_encoder = intel_ddi_get_crtc_encoder(crtc);
enum pipe pipe = intel_crtc->pipe;
enum transcoder cpu_transcoder = intel_crtc->cpu_transcoder;
int type = intel_encoder->type;
uint32_t temp;

if (type == INTEL_OUTPUT_DISPLAYPORT || type == INTEL_OUTPUT_EDP) {

temp = PIPE_MSA_SYNC_CLK;
temp = TRANS_MSA_SYNC_CLK;
switch (intel_crtc->bpp) {
case 18:
temp |= PIPE_MSA_6_BPC;
temp |= TRANS_MSA_6_BPC;
break;
case 24:
temp |= PIPE_MSA_8_BPC;
temp |= TRANS_MSA_8_BPC;
break;
case 30:
temp |= PIPE_MSA_10_BPC;
temp |= TRANS_MSA_10_BPC;
break;
case 36:
temp |= PIPE_MSA_12_BPC;
temp |= TRANS_MSA_12_BPC;
break;
default:
temp |= PIPE_MSA_8_BPC;
WARN(1, "%d bpp unsupported by pipe DDI function\n",
temp |= TRANS_MSA_8_BPC;
WARN(1, "%d bpp unsupported by DDI function\n",
intel_crtc->bpp);
}
I915_WRITE(PIPE_MSA_MISC(pipe), temp);
I915_WRITE(TRANS_MSA_MISC(cpu_transcoder), temp);
}
}

Expand Down

0 comments on commit c980979

Please sign in to comment.