Skip to content

Commit

Permalink
signals: send_group_sigqueue: don't take tasklist_lock
Browse files Browse the repository at this point in the history
handle_stop_signal() was changed, now send_group_sigqueue() doesn't need
tasklist_lock.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Oleg Nesterov authored and Linus Torvalds committed Apr 30, 2008
1 parent f8c5b5c commit c99fcf2
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions kernel/signal.c
Original file line number Diff line number Diff line change
Expand Up @@ -1335,7 +1335,6 @@ send_group_sigqueue(int sig, struct sigqueue *q, struct task_struct *p)

BUG_ON(!(q->flags & SIGQUEUE_PREALLOC));

read_lock(&tasklist_lock);
/* Since it_lock is held, p->sighand cannot be NULL. */
spin_lock_irqsave(&p->sighand->siglock, flags);

Expand All @@ -1344,7 +1343,7 @@ send_group_sigqueue(int sig, struct sigqueue *q, struct task_struct *p)
__group_complete_signal(sig, p);

spin_unlock_irqrestore(&p->sighand->siglock, flags);
read_unlock(&tasklist_lock);

return ret;
}

Expand Down

0 comments on commit c99fcf2

Please sign in to comment.