Skip to content

Commit

Permalink
dm: use unlocked variants of queue flag check/set
Browse files Browse the repository at this point in the history
dm.c already provides mutual exclusion through ->map_lock.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Jens Axboe authored and Linus Torvalds committed Apr 29, 2008
1 parent a217656 commit c9a3f6d
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions drivers/md/dm-table.c
Original file line number Diff line number Diff line change
Expand Up @@ -873,13 +873,11 @@ void dm_table_set_restrictions(struct dm_table *t, struct request_queue *q)
q->max_hw_sectors = t->limits.max_hw_sectors;
q->seg_boundary_mask = t->limits.seg_boundary_mask;
q->bounce_pfn = t->limits.bounce_pfn;
/* XXX: the below will probably go bug. must ensure there can be no
* concurrency on queue_flags, and use the unlocked versions...
*/

if (t->limits.no_cluster)
queue_flag_clear(QUEUE_FLAG_CLUSTER, q);
queue_flag_clear_unlocked(QUEUE_FLAG_CLUSTER, q);
else
queue_flag_set(QUEUE_FLAG_CLUSTER, q);
queue_flag_set_unlocked(QUEUE_FLAG_CLUSTER, q);

}

Expand Down

0 comments on commit c9a3f6d

Please sign in to comment.