Skip to content

Commit

Permalink
SELinux: do not set automatic i_ino in selinuxfs
Browse files Browse the repository at this point in the history
selinuxfs carefully uses i_ino to figure out what the inode refers to.  The
VFS used to generically set this value and we would reset it to something
useable.  After 85fe402 each filesystem sets this value to a default
if needed.  Since selinuxfs doesn't use the default value and it can only
lead to problems (I'd rather have 2 inodes with i_ino == 0 than one
pointing to the wrong data) lets just stop setting a default.

Signed-off-by: Eric Paris <eparis@redhat.com>
Acked-by: James Morris <jmorris@namei.org>
  • Loading branch information
Eric Paris committed Nov 30, 2010
1 parent 7ae9f23 commit c9e86a9
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion security/selinux/selinuxfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -989,7 +989,6 @@ static struct inode *sel_make_inode(struct super_block *sb, int mode)
struct inode *ret = new_inode(sb);

if (ret) {
ret->i_ino = get_next_ino();
ret->i_mode = mode;
ret->i_atime = ret->i_mtime = ret->i_ctime = CURRENT_TIME;
}
Expand Down

0 comments on commit c9e86a9

Please sign in to comment.