Skip to content

Commit

Permalink
sunrpc: do not pin sunrpc module in the memory
Browse files Browse the repository at this point in the history
Basically, try_module_get here are pretty useless. Any other module using
this API will pin sunrpc in memory due using exported symbols.

Signed-off-by: Denis V. Lunev <den@openvz.org>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
  • Loading branch information
Denis V. Lunev authored and Trond Myklebust committed Oct 7, 2008
1 parent fd08d7e commit c9f6cde
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions net/sunrpc/xprt.c
Original file line number Diff line number Diff line change
Expand Up @@ -108,13 +108,10 @@ int xprt_register_transport(struct xprt_class *transport)
goto out;
}

result = -EINVAL;
if (try_module_get(THIS_MODULE)) {
list_add_tail(&transport->list, &xprt_list);
printk(KERN_INFO "RPC: Registered %s transport module.\n",
transport->name);
result = 0;
}
list_add_tail(&transport->list, &xprt_list);
printk(KERN_INFO "RPC: Registered %s transport module.\n",
transport->name);
result = 0;

out:
spin_unlock(&xprt_list_lock);
Expand Down Expand Up @@ -143,7 +140,6 @@ int xprt_unregister_transport(struct xprt_class *transport)
"RPC: Unregistered %s transport module.\n",
transport->name);
list_del_init(&transport->list);
module_put(THIS_MODULE);
goto out;
}
}
Expand Down

0 comments on commit c9f6cde

Please sign in to comment.