Skip to content

Commit

Permalink
extcon: of: Remove unnecessary function call by using the name of dev…
Browse files Browse the repository at this point in the history
…ice_node

This patch remove unnecessary function call in of_extcon_get_extcon_dev()
by using the name of device_node structure.

Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
  • Loading branch information
Chanwoo Choi committed Mar 19, 2014
1 parent 3cc731d commit ca48824
Showing 1 changed file with 2 additions and 10 deletions.
12 changes: 2 additions & 10 deletions drivers/extcon/of_extcon.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ struct extcon_dev *of_extcon_get_extcon_dev(struct device *dev, int index)
{
struct device_node *node;
struct extcon_dev *edev;
struct platform_device *extcon_parent_dev;

if (!dev->of_node) {
dev_dbg(dev, "device does not have a device node entry\n");
Expand All @@ -46,16 +45,9 @@ struct extcon_dev *of_extcon_get_extcon_dev(struct device *dev, int index)
return ERR_PTR(-ENODEV);
}

extcon_parent_dev = of_find_device_by_node(node);
if (!extcon_parent_dev) {
dev_dbg(dev, "unable to find device by node\n");
return ERR_PTR(-EPROBE_DEFER);
}

edev = extcon_get_extcon_dev(dev_name(&extcon_parent_dev->dev));
edev = extcon_get_extcon_dev(node->name);
if (!edev) {
dev_dbg(dev, "unable to get extcon device : %s\n",
dev_name(&extcon_parent_dev->dev));
dev_dbg(dev, "unable to get extcon device : %s\n", node->name);
return ERR_PTR(-ENODEV);
}

Expand Down

0 comments on commit ca48824

Please sign in to comment.