Skip to content

Commit

Permalink
isci: remove base_controller abstraction
Browse files Browse the repository at this point in the history
Merge struct sci_base_controller into scic_sds_controller, and also factor
the two types of state machine handlers into one function.  While we're at
it also remove lots of duplicate incorrect kerneldoc comments for the state
machine handlers.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
  • Loading branch information
Christoph Hellwig authored and Dan Williams committed Jul 3, 2011
1 parent bc99aa4 commit ca841f0
Show file tree
Hide file tree
Showing 8 changed files with 364 additions and 638 deletions.
304 changes: 0 additions & 304 deletions drivers/scsi/isci/core/sci_base_controller.h

This file was deleted.

29 changes: 0 additions & 29 deletions drivers/scsi/isci/core/sci_controller.h
Original file line number Diff line number Diff line change
Expand Up @@ -63,36 +63,7 @@
*
*/


struct sci_base_memory_descriptor_list;
struct scic_sds_controller;

#define SCI_CONTROLLER_INVALID_IO_TAG 0xFFFF

/**
* sci_controller_get_memory_descriptor_list_handle() - This method simply
* returns a handle for the memory descriptor list associated with the
* supplied controller. The descriptor list provides DMA safe/capable
* memory requirements for this controller.
* @controller: This parameter specifies the controller for which to retrieve
* the DMA safe memory descriptor list.
*
* The user must adhere to the alignment requirements specified in memory
* descriptor. In situations where the operating environment does not offer
* memory allocation utilities supporting alignment, then it is the
* responsibility of the user to manually align the memory buffer for SCI.
* Thus, the user may have to allocate a larger buffer to meet the alignment.
* Additionally, the user will need to remember the actual memory allocation
* addresses in order to ensure the memory can be properly freed when necessary
* to do so. This method will return a valid handle, but the MDL may not be
* accurate until after the user has invoked the associated
* sci_controller_initialize() routine. A pointer to a physical memory
* descriptor array.
*/
struct sci_base_memory_descriptor_list *
sci_controller_get_memory_descriptor_list_handle(
struct scic_sds_controller *controller);


#endif /* _SCI_CONTROLLER_H_ */

Loading

0 comments on commit ca841f0

Please sign in to comment.