Skip to content

Commit

Permalink
lockd: Eliminate harmless mixed sign comparison in nlmdbg_cookie2a()
Browse files Browse the repository at this point in the history
The cookie->len field is unsigned, so the loop index variable in
nlmdbg_cookie2a() should also be unsigned.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
  • Loading branch information
Chuck Lever authored and Trond Myklebust committed Jan 30, 2008
1 parent 3d509e5 commit cab6fc1
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions fs/lockd/xdr.c
Original file line number Diff line number Diff line change
Expand Up @@ -612,8 +612,7 @@ const char *nlmdbg_cookie2a(const struct nlm_cookie *cookie)
* called with BKL held.
*/
static char buf[2*NLM_MAXCOOKIELEN+1];
int i;
int len = sizeof(buf);
unsigned int i, len = sizeof(buf);
char *p = buf;

len--; /* allow for trailing \0 */
Expand Down

0 comments on commit cab6fc1

Please sign in to comment.