Skip to content

Commit

Permalink
[PATCH] ieee1394: nodemgr: convert nodemgr_serialize semaphore to mutex
Browse files Browse the repository at this point in the history
Another trivial sem2mutex conversion.

Side note:  nodemgr_serialize's purpose, when introduced in linux1394's
revision 529 in July 2002, was to protect several data structures which
are now largely handled by or together with Linux' driver core and are
now protected by the LDM's own mechanisms.  It may very well be possible
to remove this mutex now.  But fully parallelized node scanning is on
our long-term TODO list anyway; the mutex will certainly go away then.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: Ben Collins <bcollins@ubuntu.com>
  • Loading branch information
Stefan Richter authored and Ben Collins committed Jul 3, 2006
1 parent d2f119f commit cab8d15
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions drivers/ieee1394/nodemgr.c
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ static struct csr1212_bus_ops nodemgr_csr_ops = {
* but now we are much simpler because of the LDM.
*/

static DECLARE_MUTEX(nodemgr_serialize);
static DEFINE_MUTEX(nodemgr_serialize);

struct host_info {
struct hpsb_host *host;
Expand Down Expand Up @@ -1621,7 +1621,7 @@ static int nodemgr_host_thread(void *__hi)
if (kthread_should_stop())
goto exit;

if (down_interruptible(&nodemgr_serialize)) {
if (mutex_lock_interruptible(&nodemgr_serialize)) {
if (try_to_freeze())
continue;
goto exit;
Expand Down Expand Up @@ -1650,7 +1650,7 @@ static int nodemgr_host_thread(void *__hi)
if (!nodemgr_check_irm_capability(host, reset_cycles) ||
!nodemgr_do_irm_duties(host, reset_cycles)) {
reset_cycles++;
up(&nodemgr_serialize);
mutex_unlock(&nodemgr_serialize);
continue;
}
reset_cycles = 0;
Expand All @@ -1668,10 +1668,10 @@ static int nodemgr_host_thread(void *__hi)
/* Update some of our sysfs symlinks */
nodemgr_update_host_dev_links(host);

up(&nodemgr_serialize);
mutex_unlock(&nodemgr_serialize);
}
unlock_exit:
up(&nodemgr_serialize);
mutex_unlock(&nodemgr_serialize);
exit:
HPSB_VERBOSE("NodeMgr: Exiting thread");
return 0;
Expand Down

0 comments on commit cab8d15

Please sign in to comment.