Skip to content

Commit

Permalink
tty: add missing newlines to WARN_RATELIMIT
Browse files Browse the repository at this point in the history
WARN_RATELIMIT() expects the warning to end with a newline if one
is needed.

Not doing so results in odd looking warnings such as:

[ 1339.454272] tty is NULLPid: 7147, comm: kworker/4:0 Tainted: G        W    3.7.0-rc2-next-20121025-sasha-00001-g673f98e-dirty #75

Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Sasha Levin authored and Greg Kroah-Hartman committed Oct 25, 2012
1 parent 2e30802 commit cadf748
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion drivers/tty/n_tty.c
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ static void n_tty_set_room(struct tty_struct *tty)
/* Did this open up the receive buffer? We may need to flip */
if (left && !old_left) {
WARN_RATELIMIT(tty->port->itty == NULL,
"scheduling with invalid itty");
"scheduling with invalid itty\n");
schedule_work(&tty->port->buf.work);
}
}
Expand Down
2 changes: 1 addition & 1 deletion drivers/tty/tty_buffer.c
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ static void flush_to_ldisc(struct work_struct *work)
struct tty_ldisc *disc;

tty = port->itty;
if (WARN_RATELIMIT(tty == NULL, "tty is NULL"))
if (WARN_RATELIMIT(tty == NULL, "tty is NULL\n"))
return;

disc = tty_ldisc_ref(tty);
Expand Down

0 comments on commit cadf748

Please sign in to comment.