Skip to content

Commit

Permalink
MIPS: math-emu: Mark exception handling functions as __cold.
Browse files Browse the repository at this point in the history
Optimizes the code flow and shaves of half a percent of the math-emu
code size.

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
  • Loading branch information
Ralf Baechle committed May 21, 2014
1 parent f80cc08 commit cae5506
Show file tree
Hide file tree
Showing 7 changed files with 23 additions and 16 deletions.
5 changes: 3 additions & 2 deletions arch/mips/math-emu/ieee754.c
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
* ########################################################################
*/

#include <linux/compiler.h>

#include "ieee754int.h"
#include "ieee754sp.h"
Expand Down Expand Up @@ -96,7 +97,7 @@ const struct ieee754sp_konst __ieee754sp_spcvals[] = {
};


int ieee754si_xcpt(int r, const char *op, ...)
int __cold ieee754si_xcpt(int r, const char *op, ...)
{
struct ieee754xctx ax;

Expand All @@ -111,7 +112,7 @@ int ieee754si_xcpt(int r, const char *op, ...)
return ax.rv.si;
}

s64 ieee754di_xcpt(s64 r, const char *op, ...)
s64 __cold ieee754di_xcpt(s64 r, const char *op, ...)
{
struct ieee754xctx ax;

Expand Down
3 changes: 2 additions & 1 deletion arch/mips/math-emu/ieee754.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
#ifndef __ARCH_MIPS_MATH_EMU_IEEE754_H
#define __ARCH_MIPS_MATH_EMU_IEEE754_H

#include <linux/compiler.h>
#include <asm/byteorder.h>
#include <linux/types.h>
#include <linux/sched.h>
Expand Down Expand Up @@ -421,7 +422,7 @@ struct ieee754xctx {
#define IEEE754_RT_SI 3
#define IEEE754_RT_DI 4

extern void ieee754_xcpt(struct ieee754xctx *xcp);
extern void __cold ieee754_xcpt(struct ieee754xctx *xcp);

/* compat */
#define ieee754dp_fix(x) ieee754dp_tint(x)
Expand Down
5 changes: 3 additions & 2 deletions arch/mips/math-emu/ieee754dp.c
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
* ########################################################################
*/

#include <linux/compiler.h>

#include "ieee754dp.h"

Expand All @@ -45,7 +46,7 @@ int ieee754dp_issnan(ieee754dp x)
}


ieee754dp ieee754dp_xcpt(ieee754dp r, const char *op, ...)
ieee754dp __cold ieee754dp_xcpt(ieee754dp r, const char *op, ...)
{
struct ieee754xctx ax;
if (!TSTX())
Expand All @@ -60,7 +61,7 @@ ieee754dp ieee754dp_xcpt(ieee754dp r, const char *op, ...)
return ax.rv.dp;
}

ieee754dp ieee754dp_nanxcpt(ieee754dp r, const char *op, ...)
ieee754dp __cold ieee754dp_nanxcpt(ieee754dp r, const char *op, ...)
{
struct ieee754xctx ax;

Expand Down
9 changes: 5 additions & 4 deletions arch/mips/math-emu/ieee754dp.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
* ########################################################################
*/

#include <linux/compiler.h>

#include "ieee754int.h"

Expand Down Expand Up @@ -62,10 +63,10 @@ static inline ieee754dp builddp(int s, int bx, u64 m)

extern int ieee754dp_isnan(ieee754dp);
extern int ieee754dp_issnan(ieee754dp);
extern int ieee754si_xcpt(int, const char *, ...);
extern s64 ieee754di_xcpt(s64, const char *, ...);
extern ieee754dp ieee754dp_xcpt(ieee754dp, const char *, ...);
extern ieee754dp ieee754dp_nanxcpt(ieee754dp, const char *, ...);
extern int __cold ieee754si_xcpt(int, const char *, ...);
extern s64 __cold ieee754di_xcpt(s64, const char *, ...);
extern ieee754dp __cold ieee754dp_xcpt(ieee754dp, const char *, ...);
extern ieee754dp __cold ieee754dp_nanxcpt(ieee754dp, const char *, ...);
extern ieee754dp ieee754dp_bestnan(ieee754dp, ieee754dp);
extern ieee754dp ieee754dp_format(int, int, u64);

Expand Down
5 changes: 3 additions & 2 deletions arch/mips/math-emu/ieee754sp.c
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
* ########################################################################
*/

#include <linux/compiler.h>

#include "ieee754sp.h"

Expand All @@ -45,7 +46,7 @@ int ieee754sp_issnan(ieee754sp x)
}


ieee754sp ieee754sp_xcpt(ieee754sp r, const char *op, ...)
ieee754sp __cold ieee754sp_xcpt(ieee754sp r, const char *op, ...)
{
struct ieee754xctx ax;

Expand All @@ -61,7 +62,7 @@ ieee754sp ieee754sp_xcpt(ieee754sp r, const char *op, ...)
return ax.rv.sp;
}

ieee754sp ieee754sp_nanxcpt(ieee754sp r, const char *op, ...)
ieee754sp __cold ieee754sp_nanxcpt(ieee754sp r, const char *op, ...)
{
struct ieee754xctx ax;

Expand Down
9 changes: 5 additions & 4 deletions arch/mips/math-emu/ieee754sp.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
* ########################################################################
*/

#include <linux/compiler.h>

#include "ieee754int.h"

Expand Down Expand Up @@ -68,10 +69,10 @@ static inline ieee754sp buildsp(int s, int bx, unsigned m)

extern int ieee754sp_isnan(ieee754sp);
extern int ieee754sp_issnan(ieee754sp);
extern int ieee754si_xcpt(int, const char *, ...);
extern s64 ieee754di_xcpt(s64, const char *, ...);
extern ieee754sp ieee754sp_xcpt(ieee754sp, const char *, ...);
extern ieee754sp ieee754sp_nanxcpt(ieee754sp, const char *, ...);
extern int __cold ieee754si_xcpt(int, const char *, ...);
extern s64 __cold ieee754di_xcpt(s64, const char *, ...);
extern ieee754sp __cold ieee754sp_xcpt(ieee754sp, const char *, ...);
extern ieee754sp __cold ieee754sp_nanxcpt(ieee754sp, const char *, ...);
extern ieee754sp ieee754sp_bestnan(ieee754sp, ieee754sp);
extern ieee754sp ieee754sp_format(int, int, unsigned);

Expand Down
3 changes: 2 additions & 1 deletion arch/mips/math-emu/ieee754xcpt.c
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
* Copyright (C) 2000 MIPS Technologies, Inc. All rights reserved.
*************************************************************************/

#include <linux/compiler.h>
#include <linux/kernel.h>
#include "ieee754.h"

Expand All @@ -40,7 +41,7 @@ static const char *const rtnames[] = {
"sp", "dp", "xp", "si", "di"
};

void ieee754_xcpt(struct ieee754xctx *xcp)
void __cold ieee754_xcpt(struct ieee754xctx *xcp)
{
printk(KERN_DEBUG "floating point exception in \"%s\", type=%s\n",
xcp->op, rtnames[xcp->rt]);
Expand Down

0 comments on commit cae5506

Please sign in to comment.