Skip to content

Commit

Permalink
Revert "[PATCH] USB: move usb_device_class class devices to be real d…
Browse files Browse the repository at this point in the history
…evices"

This reverts c182274 commit because it
required a newer version of udev to work properly than what is currently
documented in Documentation/Changes.

Cc: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Greg Kroah-Hartman committed Aug 2, 2006
1 parent 27fb4f0 commit cae74b3
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
20 changes: 10 additions & 10 deletions drivers/usb/core/devio.c
Original file line number Diff line number Diff line change
Expand Up @@ -517,19 +517,19 @@ static int check_ctrlrecip(struct dev_state *ps, unsigned int requesttype, unsig

static struct usb_device *usbdev_lookup_minor(int minor)
{
struct device *device;
struct usb_device *udev = NULL;
struct class_device *class_dev;
struct usb_device *dev = NULL;

down(&usb_device_class->sem);
list_for_each_entry(device, &usb_device_class->devices, node) {
if (device->devt == MKDEV(USB_DEVICE_MAJOR, minor)) {
udev = device->platform_data;
list_for_each_entry(class_dev, &usb_device_class->children, node) {
if (class_dev->devt == MKDEV(USB_DEVICE_MAJOR, minor)) {
dev = class_dev->class_data;
break;
}
}
up(&usb_device_class->sem);

return udev;
return dev;
};

/*
Expand Down Expand Up @@ -1580,16 +1580,16 @@ static void usbdev_add(struct usb_device *dev)
{
int minor = ((dev->bus->busnum-1) * 128) + (dev->devnum-1);

dev->usbfs_dev = device_create(usb_device_class, &dev->dev,
MKDEV(USB_DEVICE_MAJOR, minor),
dev->class_dev = class_device_create(usb_device_class, NULL,
MKDEV(USB_DEVICE_MAJOR, minor), &dev->dev,
"usbdev%d.%d", dev->bus->busnum, dev->devnum);

dev->usbfs_dev->platform_data = dev;
dev->class_dev->class_data = dev;
}

static void usbdev_remove(struct usb_device *dev)
{
device_unregister(dev->usbfs_dev);
class_device_unregister(dev->class_dev);
}

static int usbdev_notify(struct notifier_block *self, unsigned long action,
Expand Down
2 changes: 1 addition & 1 deletion include/linux/usb.h
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ struct usb_device {
char *serial; /* iSerialNumber string, if present */

struct list_head filelist;
struct device *usbfs_dev;
struct class_device *class_dev;
struct dentry *usbfs_dentry; /* usbfs dentry entry for the device */

/*
Expand Down

0 comments on commit cae74b3

Please sign in to comment.