Skip to content

Commit

Permalink
m68knommu: simplify the 528x UART setup code
Browse files Browse the repository at this point in the history
Simplify the UART setup code so that it no longer loops for each UART
present. Just make it do all the work it needs in a single function.
This will make the code easier to share when we move to a single set
of platform data for ColdFire UARTs.

Signed-off-by: Greg Ungerer <gerg@uclinux.org>
  • Loading branch information
Greg Ungerer committed Mar 4, 2012
1 parent 1eb1391 commit cae82a8
Showing 1 changed file with 4 additions and 18 deletions.
22 changes: 4 additions & 18 deletions arch/m68k/platform/528x/config.c
Original file line number Diff line number Diff line change
Expand Up @@ -218,28 +218,14 @@ static struct platform_device *m528x_devices[] __initdata = {

/***************************************************************************/

static void __init m528x_uart_init_line(int line, int irq)
static void __init m528x_uarts_init(void)
{
u8 port;

if ((line < 0) || (line > 2))
return;

/* make sure PUAPAR is set for UART0 and UART1 */
if (line < 2) {
port = readb(MCF5282_GPIO_PUAPAR);
port |= (0x03 << (line * 2));
writeb(port, MCF5282_GPIO_PUAPAR);
}
}

static void __init m528x_uarts_init(void)
{
const int nrlines = ARRAY_SIZE(m528x_uart_platform);
int line;

for (line = 0; (line < nrlines); line++)
m528x_uart_init_line(line, m528x_uart_platform[line].irq);
port = readb(MCF5282_GPIO_PUAPAR);
port |= 0x03 | (0x03 << 2);
writeb(port, MCF5282_GPIO_PUAPAR);
}

/***************************************************************************/
Expand Down

0 comments on commit cae82a8

Please sign in to comment.