Skip to content

Commit

Permalink
ksz884x: Use kzalloc rather than kmalloc followed by memset with 0
Browse files Browse the repository at this point in the history
This considers some simple cases that are common and easy to validate
Note in particular that there are no ...s in the rule, so all of the
matched code has to be contiguous

The semantic patch that makes this change is available
in scripts/coccinelle/api/alloc/kzalloc-simple.cocci.

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Thomas Meyer authored and David S. Miller committed Nov 21, 2011
1 parent 7a2da3d commit cb50870
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions drivers/net/ethernet/micrel/ksz884x.c
Original file line number Diff line number Diff line change
Expand Up @@ -4380,12 +4380,10 @@ static void ksz_update_timer(struct ksz_timer_info *info)
*/
static int ksz_alloc_soft_desc(struct ksz_desc_info *desc_info, int transmit)
{
desc_info->ring = kmalloc(sizeof(struct ksz_desc) * desc_info->alloc,
GFP_KERNEL);
desc_info->ring = kzalloc(sizeof(struct ksz_desc) * desc_info->alloc,
GFP_KERNEL);
if (!desc_info->ring)
return 1;
memset((void *) desc_info->ring, 0,
sizeof(struct ksz_desc) * desc_info->alloc);
hw_init_desc(desc_info, transmit);
return 0;
}
Expand Down

0 comments on commit cb50870

Please sign in to comment.