Skip to content

Commit

Permalink
sched: optimize effective_load()
Browse files Browse the repository at this point in the history
s_i = S * rw_i / \Sum_j rw_j

 -> \Sum_j rw_j = S * rw_i / s_i

 -> s'_i = S * (rw_i + w) / (\Sum_j rw_j + w)

delta s = s' - s = S * (rw + w) / ((S * rw / s) + w)
        = s * (S * (rw + w) / (S * rw + s * w) - 1)

 a = S*(rw+w), b = S*rw + s*w

delta s = s * (a-b) / b

IOW, trade one divide for two multiplies

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
Cc: Mike Galbraith <efault@gmx.de>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Peter Zijlstra authored and Ingo Molnar committed Jun 27, 2008
1 parent 051c676 commit cb5ef42
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions kernel/sched_fair.c
Original file line number Diff line number Diff line change
Expand Up @@ -1082,16 +1082,16 @@ static unsigned long effective_load(struct task_group *tg, long wl, int cpu)
for_each_sched_entity(se) {
#define D(n) (likely(n) ? (n) : 1)

long S, Srw, rw, s, sn;
long S, rw, s, a, b;

S = se->my_q->tg->shares;
s = se->my_q->shares;
rw = se->my_q->load.weight;

Srw = S * rw / D(s);
sn = S * (rw + wl) / D(Srw + wg);
a = S*(rw + wl);
b = S*rw + s*wg;

wl = sn - s;
wl = s*(a-b)/D(b);
wg = 0;
#undef D
}
Expand Down

0 comments on commit cb5ef42

Please sign in to comment.