Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 171389
b: refs/heads/master
c: 3779752
h: refs/heads/master
i:
  171387: bab4857
v: v3
  • Loading branch information
Lennert Buytenhek authored and John W. Linville committed Nov 4, 2009
1 parent b491dda commit cb69ff8
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 23 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: d5e308457e8e9b4988fbd69d38c30782125b3f65
refs/heads/master: 3779752d764b86077375510b1fd13d8fb2c7c3a5
28 changes: 6 additions & 22 deletions trunk/drivers/net/wireless/mwl8k.c
Original file line number Diff line number Diff line change
Expand Up @@ -195,9 +195,6 @@ struct mwl8k_priv {

/* Tasklet to reclaim TX descriptors and buffers after tx */
struct tasklet_struct tx_reclaim_task;

/* Work thread to serialize configuration requests */
struct workqueue_struct *config_wq;
};

/* Per interface specific private data */
Expand Down Expand Up @@ -881,9 +878,11 @@ mwl8k_capture_bssid(struct mwl8k_priv *priv, struct ieee80211_hdr *wh)
!compare_ether_addr(wh->addr3, priv->capture_bssid);
}

static inline void mwl8k_save_beacon(struct mwl8k_priv *priv,
struct sk_buff *skb)
static inline void mwl8k_save_beacon(struct ieee80211_hw *hw,
struct sk_buff *skb)
{
struct mwl8k_priv *priv = hw->priv;

priv->capture_beacon = false;
memset(priv->capture_bssid, 0, ETH_ALEN);

Expand All @@ -894,8 +893,7 @@ static inline void mwl8k_save_beacon(struct mwl8k_priv *priv,
*/
priv->beacon_skb = skb_copy(skb, GFP_ATOMIC);
if (priv->beacon_skb != NULL)
queue_work(priv->config_wq,
&priv->finalize_join_worker);
ieee80211_queue_work(hw, &priv->finalize_join_worker);
}

static int rxq_process(struct ieee80211_hw *hw, int index, int limit)
Expand Down Expand Up @@ -940,7 +938,7 @@ static int rxq_process(struct ieee80211_hw *hw, int index, int limit)
* send a FINALIZE_JOIN command to the firmware.
*/
if (mwl8k_capture_bssid(priv, wh))
mwl8k_save_beacon(priv, skb);
mwl8k_save_beacon(hw, skb);

memset(&status, 0, sizeof(status));
status.mactime = 0;
Expand Down Expand Up @@ -2504,9 +2502,6 @@ static void mwl8k_stop(struct ieee80211_hw *hw)
/* Stop tx reclaim tasklet */
tasklet_disable(&priv->tx_reclaim_task);

/* Stop config thread */
flush_workqueue(priv->config_wq);

/* Return all skbs to mac80211 */
for (i = 0; i < MWL8K_TX_QUEUES; i++)
mwl8k_txq_reclaim(hw, i, 1);
Expand Down Expand Up @@ -2920,11 +2915,6 @@ static int __devinit mwl8k_probe(struct pci_dev *pdev,
mwl8k_tx_reclaim_handler, (unsigned long)hw);
tasklet_disable(&priv->tx_reclaim_task);

/* Config workthread */
priv->config_wq = create_singlethread_workqueue("mwl8k_config");
if (priv->config_wq == NULL)
goto err_iounmap;

/* Power management cookie */
priv->cookie = pci_alloc_consistent(priv->pdev, 4, &priv->cookie_dma);
if (priv->cookie == NULL)
Expand Down Expand Up @@ -3047,9 +3037,6 @@ static int __devinit mwl8k_probe(struct pci_dev *pdev,
if (priv->regs != NULL)
pci_iounmap(pdev, priv->regs);

if (priv->config_wq != NULL)
destroy_workqueue(priv->config_wq);

pci_set_drvdata(pdev, NULL);
ieee80211_free_hw(hw);

Expand Down Expand Up @@ -3082,9 +3069,6 @@ static void __devexit mwl8k_remove(struct pci_dev *pdev)
/* Remove tx reclaim tasklet */
tasklet_kill(&priv->tx_reclaim_task);

/* Stop config thread */
destroy_workqueue(priv->config_wq);

/* Stop hardware */
mwl8k_hw_reset(priv);

Expand Down

0 comments on commit cb69ff8

Please sign in to comment.