Skip to content

Commit

Permalink
arch/powerpc: Move dma_mask from of_device into pdev_archdata
Browse files Browse the repository at this point in the history
By moving dma_mask into pdev_archdata, and adding archdata to
struct of_device, it makes it possible to substitute of_device
with struct platform_device, which is a stepping stone to
removing the of_platform bus entirely.

Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
  • Loading branch information
Grant Likely committed May 22, 2010
1 parent 58f9b0b commit cb6dc51
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 7 deletions.
1 change: 1 addition & 0 deletions arch/powerpc/include/asm/device.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ struct dev_archdata {
};

struct pdev_archdata {
u64 dma_mask;
};

#endif /* _ASM_POWERPC_DEVICE_H */
2 changes: 1 addition & 1 deletion arch/powerpc/include/asm/of_device.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
*/
struct of_device
{
u64 dma_mask; /* DMA mask */
struct device dev; /* Generic device interface */
struct pdev_archdata archdata;
};

extern struct of_device *of_device_alloc(struct device_node *np,
Expand Down
2 changes: 1 addition & 1 deletion arch/powerpc/kernel/of_device.c
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ struct of_device *of_device_alloc(struct device_node *np,
return NULL;

dev->dev.of_node = of_node_get(np);
dev->dev.dma_mask = &dev->dma_mask;
dev->dev.dma_mask = &dev->archdata.dma_mask;
dev->dev.parent = parent;
dev->dev.release = of_release_dev;

Expand Down
2 changes: 1 addition & 1 deletion arch/powerpc/kernel/of_platform.c
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ struct of_device* of_platform_device_create(struct device_node *np,
if (!dev)
return NULL;

dev->dma_mask = 0xffffffffUL;
dev->archdata.dma_mask = 0xffffffffUL;
dev->dev.coherent_dma_mask = DMA_BIT_MASK(32);

dev->dev.bus = &of_platform_bus_type;
Expand Down
4 changes: 2 additions & 2 deletions drivers/macintosh/macio_asic.c
Original file line number Diff line number Diff line change
Expand Up @@ -374,8 +374,8 @@ static struct macio_dev * macio_add_one_device(struct macio_chip *chip,
dev->bus = &chip->lbus;
dev->media_bay = in_bay;
dev->ofdev.dev.of_node = np;
dev->ofdev.dma_mask = 0xffffffffUL;
dev->ofdev.dev.dma_mask = &dev->ofdev.dma_mask;
dev->ofdev.archdata.dma_mask = 0xffffffffUL;
dev->ofdev.dev.dma_mask = &dev->ofdev.archdata.dma_mask;
dev->ofdev.dev.parent = parent;
dev->ofdev.dev.bus = &macio_bus_type;
dev->ofdev.dev.release = macio_release_dev;
Expand Down
4 changes: 2 additions & 2 deletions sound/aoa/soundbus/i2sbus/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -221,9 +221,9 @@ static int i2sbus_add_dev(struct macio_dev *macio,

mutex_init(&dev->lock);
spin_lock_init(&dev->low_lock);
dev->sound.ofdev.dma_mask = macio->ofdev.dma_mask;
dev->sound.ofdev.archdata.dma_mask = macio->ofdev.archdata.dma_mask;
dev->sound.ofdev.dev.of_node = np;
dev->sound.ofdev.dev.dma_mask = &dev->sound.ofdev.dma_mask;
dev->sound.ofdev.dev.dma_mask = &dev->sound.ofdev.archdata.dma_mask;
dev->sound.ofdev.dev.parent = &macio->ofdev.dev;
dev->sound.ofdev.dev.release = i2sbus_release_dev;
dev->sound.attach_codec = i2sbus_attach_codec;
Expand Down

0 comments on commit cb6dc51

Please sign in to comment.