Skip to content

Commit

Permalink
bnx2: remove cancel_work_sync() from remove_one
Browse files Browse the repository at this point in the history
Michael pointed out that bnx2_close() already cancels bp->reset_task
and thus it is guaranteed to be idle when bnx2_remove_one() is called.
Remove the unnecessary cancel_work_sync() in remove_one.

Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Tejun Heo authored and David S. Miller committed Dec 21, 2010
1 parent a13c132 commit cb8f404
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/net/bnx2.c
Original file line number Diff line number Diff line change
Expand Up @@ -8393,8 +8393,6 @@ bnx2_remove_one(struct pci_dev *pdev)
struct net_device *dev = pci_get_drvdata(pdev);
struct bnx2 *bp = netdev_priv(dev);

cancel_work_sync(&bp->reset_task);

unregister_netdev(dev);

if (bp->mips_firmware)
Expand Down

0 comments on commit cb8f404

Please sign in to comment.