Skip to content

Commit

Permalink
[PATCH] Bogus NULL pointer check in fs/configfs/dir.c
Browse files Browse the repository at this point in the history
We check the "group" pointer after we dereference it.  This check is
bogus, as it cannot be NULL coming in.

Signed-off-by: Joel Becker <joel.becker@oracle.com>
Signed-off-by: Mark Fasheh <mark.fasheh@oracle.com>
  • Loading branch information
Eric Sesterhenn authored and Mark Fasheh committed Apr 10, 2006
1 parent a9e2ae3 commit cbca692
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/configfs/dir.c
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@ static int populate_groups(struct config_group *group)
int ret = 0;
int i;

if (group && group->default_groups) {
if (group->default_groups) {
/* FYI, we're faking mkdir here
* I'm not sure we need this semaphore, as we're called
* from our parent's mkdir. That holds our parent's
Expand Down

0 comments on commit cbca692

Please sign in to comment.