Skip to content

Commit

Permalink
staging: comedi: adv_pci1723: move comedi_pci_enable() into the attach
Browse files Browse the repository at this point in the history
Use pci_is_enabled() in the "find pci device" function to determine if
the found pci device is not in use and move the comedi_pci_enable() call
into the attach.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
H Hartley Sweeten authored and Greg Kroah-Hartman committed Jul 19, 2012
1 parent 3dbd666 commit cc04c8a
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions drivers/staging/comedi/drivers/adv_pci1723.c
Original file line number Diff line number Diff line change
Expand Up @@ -302,11 +302,7 @@ static struct pci_dev *pci1723_find_pci_dev(struct comedi_device *dev,
}
if (pcidev->vendor != PCI_VENDOR_ID_ADVANTECH)
continue;
/*
* Look for device that isn't in use.
* Enable PCI device and request regions.
*/
if (comedi_pci_enable(pcidev, "adv_pci1723"))
if (pci_is_enabled(pcidev))
continue;
return pcidev;
}
Expand Down Expand Up @@ -335,6 +331,10 @@ static int pci1723_attach(struct comedi_device *dev,
if (!devpriv->pcidev)
return -EIO;

ret = comedi_pci_enable(devpriv->pcidev, "adv_pci1723");
if (ret)
return ret;

dev->iobase = pci_resource_start(devpriv->pcidev, 2);

dev->board_name = this_board->name;
Expand Down

0 comments on commit cc04c8a

Please sign in to comment.