Skip to content

Commit

Permalink
gpio/pca953x: Use handle_simple_irq instead of handle_edge_irq
Browse files Browse the repository at this point in the history
Make pca953x driver use the simple irq handler since no hardware control
is necessary and the driver lacks an irq_ack function. handle_edge_irq()
calls chip->irq_ack() which crashes since this function does not exist.

Signed-off-by: Erik Botö <erik.boto@pelagicore.com>
Signed-off-by: Richard Röjfors <richard.rojfors@pelagicore.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
  • Loading branch information
Erik Botö authored and Grant Likely committed May 20, 2011
1 parent 8fa0c9b commit cc300d9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpio/pca953x.c
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ static int pca953x_irq_setup(struct pca953x_chip *chip,

irq_set_chip_data(irq, chip);
irq_set_chip_and_handler(irq, &pca953x_irq_chip,
handle_edge_irq);
handle_simple_irq);
#ifdef CONFIG_ARM
set_irq_flags(irq, IRQF_VALID);
#else
Expand Down

0 comments on commit cc300d9

Please sign in to comment.