Skip to content

Commit

Permalink
usb: exynos: do not include plat/usb-phy.h
Browse files Browse the repository at this point in the history
The definitions have moved to include/linux/usb/samsung-usb-phy.h,
and plat/usb-phy.h is unavailable from drivers in a multiplatform
configuration.

Also fix up the plat/usb-phy.h header file to use the definitions
from the new header instead of providing a separate copy.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Arnd Bergmann authored and Greg Kroah-Hartman committed Apr 11, 2013
1 parent 2871782 commit cccfc53
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 14 deletions.
8 changes: 4 additions & 4 deletions arch/arm/mach-exynos/setup-usb-phy.c
Original file line number Diff line number Diff line change
Expand Up @@ -204,19 +204,19 @@ static int exynos4210_usb_phy1_exit(struct platform_device *pdev)

int s5p_usb_phy_init(struct platform_device *pdev, int type)
{
if (type == S5P_USB_PHY_DEVICE)
if (type == USB_PHY_TYPE_DEVICE)
return exynos4210_usb_phy0_init(pdev);
else if (type == S5P_USB_PHY_HOST)
else if (type == USB_PHY_TYPE_HOST)
return exynos4210_usb_phy1_init(pdev);

return -EINVAL;
}

int s5p_usb_phy_exit(struct platform_device *pdev, int type)
{
if (type == S5P_USB_PHY_DEVICE)
if (type == USB_PHY_TYPE_DEVICE)
return exynos4210_usb_phy0_exit(pdev);
else if (type == S5P_USB_PHY_HOST)
else if (type == USB_PHY_TYPE_HOST)
return exynos4210_usb_phy1_exit(pdev);

return -EINVAL;
Expand Down
4 changes: 2 additions & 2 deletions arch/arm/mach-s3c64xx/setup-usb-phy.c
Original file line number Diff line number Diff line change
Expand Up @@ -76,15 +76,15 @@ static int s3c_usb_otgphy_exit(struct platform_device *pdev)

int s5p_usb_phy_init(struct platform_device *pdev, int type)
{
if (type == S5P_USB_PHY_DEVICE)
if (type == USB_PHY_TYPE_DEVICE)
return s3c_usb_otgphy_init(pdev);

return -EINVAL;
}

int s5p_usb_phy_exit(struct platform_device *pdev, int type)
{
if (type == S5P_USB_PHY_DEVICE)
if (type == USB_PHY_TYPE_DEVICE)
return s3c_usb_otgphy_exit(pdev);

return -EINVAL;
Expand Down
4 changes: 2 additions & 2 deletions arch/arm/mach-s5pv210/setup-usb-phy.c
Original file line number Diff line number Diff line change
Expand Up @@ -80,15 +80,15 @@ static int s5pv210_usb_otgphy_exit(struct platform_device *pdev)

int s5p_usb_phy_init(struct platform_device *pdev, int type)
{
if (type == S5P_USB_PHY_DEVICE)
if (type == USB_PHY_TYPE_DEVICE)
return s5pv210_usb_otgphy_init(pdev);

return -EINVAL;
}

int s5p_usb_phy_exit(struct platform_device *pdev, int type)
{
if (type == S5P_USB_PHY_DEVICE)
if (type == USB_PHY_TYPE_DEVICE)
return s5pv210_usb_otgphy_exit(pdev);

return -EINVAL;
Expand Down
5 changes: 1 addition & 4 deletions arch/arm/plat-samsung/include/plat/usb-phy.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,7 @@
#ifndef __PLAT_SAMSUNG_USB_PHY_H
#define __PLAT_SAMSUNG_USB_PHY_H __FILE__

enum s5p_usb_phy_type {
S5P_USB_PHY_DEVICE,
S5P_USB_PHY_HOST,
};
#include <linux/usb/samsung_usb_phy.h>

extern int s5p_usb_phy_init(struct platform_device *pdev, int type);
extern int s5p_usb_phy_exit(struct platform_device *pdev, int type);
Expand Down
1 change: 0 additions & 1 deletion drivers/usb/host/ehci-s5p.c
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
#include <linux/platform_data/usb-ehci-s5p.h>
#include <linux/usb/phy.h>
#include <linux/usb/samsung_usb_phy.h>
#include <plat/usb-phy.h>
#include <linux/usb.h>
#include <linux/usb/hcd.h>
#include <linux/usb/otg.h>
Expand Down
1 change: 0 additions & 1 deletion drivers/usb/host/ohci-exynos.c
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
#include <linux/platform_data/usb-exynos.h>
#include <linux/usb/phy.h>
#include <linux/usb/samsung_usb_phy.h>
#include <plat/usb-phy.h>

struct exynos_ohci_hcd {
struct device *dev;
Expand Down

0 comments on commit cccfc53

Please sign in to comment.